Conversation
|
|
| string storage_class = 5; | ||
| // server side encryption | ||
| bool sse = 6; | ||
| string sse = 6; |
There was a problem hiding this comment.
@overvenus does this 6 need to be changed to another tag?
There was a problem hiding this comment.
I think it's okay to keep 6 since the new S3 is not used yet. BTW, why does it need to be changed to string?
There was a problem hiding this comment.
It is a string instead of bool, please check detail here.
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Tennix <tennix@users.noreply.github.com> Signed-off-by: kennytm <kennytm@gmail.com>
Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com> Co-authored-by: Tennix <tennix@users.noreply.github.com> Signed-off-by: kennytm <kennytm@gmail.com>
The kvproto for S3 is not updated in tikv/tikv#6186, I think @yiwu-arbug should update the kvproto for S3. |
|
Yes, tikv/tikv#6186 was merged before this PR, so a separated PR is need to update kvproto on TiKV master again. No need to cherry-pick to TiKV 3.1 though, I've included this in tikv/tikv#6207 already. |
SSE configures the server-side encryption algorithm used when storing this object in S3 and the type should be string.