*: use kvproto::backup::StorageBackend in create_storage (#6186)#6207
*: use kvproto::backup::StorageBackend in create_storage (#6186)#6207overvenus merged 4 commits intotikv:release-3.1from
Conversation
Signed-off-by: kennytm <kennytm@gmail.com>
d36589d to
3f04236
Compare
src/import/sst_importer.rs
Outdated
| debug!("download start"; | ||
| "meta" => ?meta, | ||
| "url" => url, | ||
| "url" => ?backend, |
There was a problem hiding this comment.
The backend may contain secret data. I'm not sure if it's a good idea to log it.
There was a problem hiding this comment.
@tennix how about just log the URL s3://bucket/prefix/? (we need to forward-port the patch to master)
There was a problem hiding this comment.
There is no url field, for debug purpose, I think all other parameters need to be logged. For the secret, I think we should print <hidden-secret> or whatever meaningful for non-empty secret, and empty for empty secret.
There was a problem hiding this comment.
the struct is generated by protobuf/prost so I don't think we can control its debug output (unless we use a custom formatter)
Signed-off-by: kennytm <kennytm@gmail.com>
|
PTAL @tennix @overvenus |
|
Unfortunately, this PR is blocked by #6181 . 😿 |
|
/run-all-tests |
|
/run-all-tests |
What have you changed?
Please explain in detail what the changes are in this PR and why they are needed:
What is the type of the changes?
Pick one of the following and delete the others:
How is the PR tested?
Please select the tests that you ran to verify your changes:
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No
Refer to a related PR or issue link (optional)
pingcap/br#88
Benchmark result if necessary (optional)
Any examples? (optional)