This repository was archived by the owner on Jul 24, 2024. It is now read-only.
*: extract storage package, and update kvproto#88
Merged
Conversation
44b1b9e to
4ea349e
Compare
4ea349e to
5c1a7c8
Compare
| // FormatBackendURL obtains the raw URL which can be used the reconstruct the | ||
| // backend. The returned URL does not contain options for further configurating | ||
| // the backend. This is to avoid exposing secret tokens. | ||
| func FormatBackendURL(backend *backup.StorageBackend) (u url.URL) { |
Contributor
There was a problem hiding this comment.
It's only used for log now in the SaveBackMeta.
pkg/storage/s3.go
Outdated
| // S3EndpointOption is a BackendOption for changing the endpoint of the storage. | ||
| type S3Endpoint struct { | ||
| backendOption | ||
| // Endpoint is the host name of the S3 endpoint. |
Contributor
There was a problem hiding this comment.
This should be in the format of http[s]://host[:port], right?
Collaborator
Author
There was a problem hiding this comment.
Yes. But Go's AWS SDK accepts just host:port too (and they use another flag to determine whether to use HTTPS).
96fbeef to
6acc073
Compare
Member
|
Linter reports some suggestions, could you address them? |
6dc17a2 to
bb3a96b
Compare
bb3a96b to
100dfde
Compare
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 30 30
Lines 2620 2620
=======================================
Hits 1749 1749
Misses 629 629
Partials 242 242Continue to review full report at Codecov.
|
Member
|
/run-integration-tests |
Signed-off-by: Neil Shen <overvenus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg/utilintopkg/storage. In the future I'd like to further move them intopingcap/tidb-toolsso it could be reused by Lightning and Dumpling.Closes #71.