Skip to content

azblob: use copy to implement read_to_end (#18419)#18781

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-7.5-20250804-v7.5.6from
YuJuncen:release-7.5-20250804-v7.5.6
Aug 4, 2025
Merged

azblob: use copy to implement read_to_end (#18419)#18781
ti-chi-bot[bot] merged 2 commits intotikv:release-7.5-20250804-v7.5.6from
YuJuncen:release-7.5-20250804-v7.5.6

Conversation

@YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Aug 4, 2025

This is an automated cherry-pick of #18411

What is changed and how it works?

Issue Number: Close #18410

What's Changed:

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause flush operation slow in azure blob storage.

ti-chi-bot and others added 2 commits August 4, 2025 12:34
close tikv#18410

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the dco. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2025
@YuJuncen YuJuncen changed the base branch from master to release-7.5-20250804-v7.5.6 August 4, 2025 04:57
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 4, 2025
@YuJuncen YuJuncen closed this Aug 4, 2025
@YuJuncen YuJuncen reopened this Aug 4, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 4, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 4, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-04 06:05:32.478282499 +0000 UTC m=+248242.621043664: ☑️ agreed by Leavrth.
  • 2025-08-04 06:51:31.648421972 +0000 UTC m=+251001.791183147: ☑️ agreed by 3pointer.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, iosmanthus, Leavrth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 4, 2025
@ti-chi-bot ti-chi-bot bot merged commit 69f275f into tikv:release-7.5-20250804-v7.5.6 Aug 4, 2025
7 of 8 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18782.

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Aug 4, 2025
close tikv#18410

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #18783.
But this PR has conflicts, please resolve them!

ti-chi-bot bot pushed a commit that referenced this pull request Sep 17, 2025
close #18410

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Azureblob upload may be slow when reading from non-memory source

5 participants