Skip to content

azblob: use copy to implement read_to_end (#18411)#18419

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-18411-to-release-7.5
Jul 22, 2025
Merged

azblob: use copy to implement read_to_end (#18411)#18419
ti-chi-bot[bot] merged 3 commits intotikv:release-7.5from
ti-chi-bot:cherry-pick-18411-to-release-7.5

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #18411

What is changed and how it works?

Issue Number: Close #18410

What's Changed:

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause flush operation slow in azure blob storage.

close tikv#18410

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Apr 27, 2025
@ti-chi-bot
Copy link
Member Author

@YuJuncen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 27, 2025
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 2, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Jul 7, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 21, 2025
@YuJuncen
Copy link
Contributor

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 22, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 22, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-07-21 05:57:26.364560488 +0000 UTC m=+217483.285704464: ☑️ agreed by YuJuncen.
  • 2025-07-22 05:05:20.997651531 +0000 UTC m=+54677.735077728: ☑️ agreed by 3pointer.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YuJuncen
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2025
@YuJuncen
Copy link
Contributor

/hold cancel

@ti-chi-bot ti-chi-bot bot merged commit 1b3bfcf into tikv:release-7.5 Jul 22, 2025
4 checks passed
YuJuncen added a commit that referenced this pull request Aug 4, 2025
close #18410

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 4, 2025
close #18410

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
Signed-off-by: hillium <yu745514916@live.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved and removed cherry-pick-approved Cherry pick PR approved by release team. labels Aug 4, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

ti-chi-bot bot pushed a commit that referenced this pull request Sep 17, 2025
close #18410

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>

Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com>
Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/cherry-pick-not-approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants