azblob: use copy to implement read_to_end#18411
Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom Apr 25, 2025
Merged
Conversation
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
Leavrth
approved these changes
Apr 23, 2025
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
3pointer
approved these changes
Apr 25, 2025
Contributor
iosmanthus
approved these changes
Apr 25, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, iosmanthus, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/run-cherry-picker |
ti-chi-bot
pushed a commit
to ti-chi-bot/tikv
that referenced
this pull request
Apr 27, 2025
close tikv#18410 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
Member
|
In response to a cherrypick label: new pull request created to branch |
9 tasks
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 8, 2025
close #18410 Now `azblob` uses io::copy instead of `read_to_end` to read contents. Signed-off-by: Juncen Yu <yujuncen@pingcap.com> Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
ti-chi-bot bot
pushed a commit
that referenced
this pull request
Jul 22, 2025
close #18410 Now `azblob` uses io::copy instead of `read_to_end` to read contents. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Juncen Yu <yujuncen@pingcap.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
YuJuncen
added a commit
that referenced
this pull request
Aug 4, 2025
close #18410 Now `azblob` uses io::copy instead of `read_to_end` to read contents. Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: Juncen Yu <yujuncen@pingcap.com> Co-authored-by: 山岚 <36239017+YuJuncen@users.noreply.github.com> Co-authored-by: Juncen Yu <yujuncen@pingcap.com>
9 tasks
This was referenced Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed and how it works?
Issue Number: Close #18410
What's Changed:
Diff (In the scenario of reading 2 bytes per read, about 50x faster):
For more details, check the benchmark
bench[_manual]_read_to_endincomponents/cloud/src/blob.rs.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note