Skip to content

azblob: use copy to implement read_to_end (#18419) (#18781)#18783

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18781-to-release-8.5
Sep 17, 2025
Merged

azblob: use copy to implement read_to_end (#18419) (#18781)#18783
ti-chi-bot[bot] merged 3 commits intotikv:release-8.5from
ti-chi-bot:cherry-pick-18781-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 4, 2025

This is an automated cherry-pick of #18781

This is an automated cherry-pick of #18411

What is changed and how it works?

Issue Number: Close #18410

What's Changed:

Now `azblob` uses io::copy instead of `read_to_end` to read contents.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

Fixed a bug that may cause flush operation slow in azure blob storage.

@YuJuncen @ti-chi-bot
This is an automated cherry-pick of tikv#18781
022ead6 
close tikv#18410

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 4, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 4, 2025
Merged
9 tasks
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 4, 2025

@YuJuncen This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 4, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 4, 2025
@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 28, 2025
@YuJuncen
resolve conflicts
1ff095f 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
YuJuncen
YuJuncen approved these changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@YuJuncen YuJuncen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think check-dep should be fixed by some other PR... I didn't modify kvproto dep.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 17, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-17 02:42:58.998235252 +0000 UTC m=+1020445.558116739: ☑️ agreed by YuJuncen.
  • 2025-09-17 02:57:05.457039114 +0000 UTC m=+1021292.016920610: ☑️ agreed by Leavrth.

@YuJuncen
Copy link
Contributor

YuJuncen commented Sep 17, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2025
@YuJuncen
try fix check-deps
dc15375 
Signed-off-by: Juncen Yu <yujuncen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 17, 2025
@YuJuncen
Copy link
Contributor

YuJuncen commented Sep 17, 2025

/test pull-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 3255d95 into tikv:release-8.5 Sep 17, 2025
5 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-18781-to-release-8.5 branch September 17, 2025 04:50
@Connor1996 Connor1996 mentioned this pull request Sep 17, 2025
Closed
9 tasks
@qiancai qiancai mentioned this pull request Oct 15, 2025
Merged
14 tasks
@qiancai qiancai mentioned this pull request Nov 12, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@YuJuncen YuJuncen

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @YuJuncen @Leavrth