import: call sink.fail() when failed to send message by grpc by joccau · Pull Request #17834 · tikv/tikv

joccau · 2024-11-15T07:37:29Z

What is changed and how it works?

Issue Number: Close #17830

What's Changed:

it should call sink.fail() not sink.close() when failed to send message in cause of RemoteStopped.

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
Need to cherry-pick to the release branch

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No code

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Release note

None

Signed-off-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot · 2024-11-15T07:37:39Z

Hi @joccau. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau · 2024-11-18T05:47:47Z

@kennytm @YuJuncen @3pointer @Leavrth PTAL

joccau · 2024-11-18T05:49:48Z

/cc @kennytm @YuJuncen @3pointer @Leavrth PTAL~

YuJuncen

rest lgtm

YuJuncen · 2024-11-18T07:38:16Z

tests/integrations/import/test_sst_service.rs

 }

+#[test]
+fn test_duplicate_detect_with_client_stop() {


I guess test cases with failpoints enabled should be put in the failpoints dir, or the failpoint may race with other cases...

I guess test cases with failpoints enabled should be put in the failpoints dir, or the failpoint may race with other cases...

Already moved this case to failpoint dir.

ti-chi-bot · 2024-11-19T14:36:58Z

In response to a cherrypick label: new pull request created to branch release-7.1: #17861.

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-19T14:36:59Z

In response to a cherrypick label: new pull request created to branch release-8.1: #17862.

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-19T14:37:00Z

In response to a cherrypick label: new pull request created to branch release-6.5: #17863.

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2024-11-19T14:37:02Z

In response to a cherrypick label: new pull request created to branch release-7.5: #17864.

…#17861) close #17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: joccau <zak.zhao@pingcap.cn> Co-authored-by: Zack Zhao <57036248+joccau@users.noreply.github.com> Co-authored-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot · 2024-11-25T11:42:29Z

In response to a cherrypick label: new pull request created to branch release-8.5: #17893.

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

…#17893) close #17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io> Signed-off-by: joccau <zak.zhao@pingcap.cn> Co-authored-by: Zack Zhao <57036248+joccau@users.noreply.github.com> Co-authored-by: joccau <zak.zhao@pingcap.cn>

…#17864) close #17830 Signed-off-by: joccau <zak.zhao@pingcap.cn> Co-authored-by: joccau <zak.zhao@pingcap.cn>

joccau · 2025-02-16T01:21:32Z

/remove-label needs-cherry-pick-release-6.5

joechenrh · 2025-08-05T05:37:46Z

/cherrypick release-6.5-20250805-v6.5.12

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot · 2025-08-05T05:38:25Z

@joechenrh: new pull request created to branch release-6.5-20250805-v6.5.12: #18789.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherrypick release-6.5-20250805-v6.5.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

…#18789) close #17830 Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn> Co-authored-by: Ruihao Chen <ruihao.chen@pingcap.cn>

call sink.fail() when failed to send rpc

24384c2

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau changed the title ~~import: call sink.fail() when failed to send message by grpc~~ [wip]import: call sink.fail() when failed to send message by grpc Nov 15, 2024

ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 15, 2024

joccau changed the title ~~[wip]import: call sink.fail() when failed to send message by grpc~~ import: call sink.fail() when failed to send message by grpc Nov 16, 2024

ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 16, 2024

add test

2004a8c

Signed-off-by: joccau <zak.zhao@pingcap.cn>

joccau force-pushed the fix-fail-sink branch from 17bf490 to 2004a8c Compare November 16, 2024 07:08

add test with failpoint

f385f87

Signed-off-by: joccau <zak.zhao@pingcap.cn>

YuJuncen approved these changes Nov 19, 2024

View reviewed changes

ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024

Leavrth approved these changes Nov 19, 2024

View reviewed changes

ti-chi-bot bot added needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Nov 19, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024

This is an automated cherry-pick of tikv#17834

145c5a6

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024

This is an automated cherry-pick of tikv#17834

2ee5ad0

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 19, 2024

import: call sink.fail() when failed to send message by grpc (#17834) #17861

Merged

9 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024

This is an automated cherry-pick of tikv#17834

5ee701c

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 19, 2024

import: call sink.fail() when failed to send message by grpc (#17834) #17862

Open

9 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 19, 2024

This is an automated cherry-pick of tikv#17834

5e45c33

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 19, 2024

import: call sink.fail() when failed to send message by grpc (#17834) #17863

Closed

9 tasks

ti-chi-bot mentioned this pull request Nov 19, 2024

import: call sink.fail() when failed to send message by grpc (#17834) #17864

Merged

9 tasks

ti-chi-bot bot added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Nov 25, 2024

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Nov 25, 2024

This is an automated cherry-pick of tikv#17834

99f2193

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Nov 25, 2024

import: call sink.fail() when failed to send message by grpc (#17834) #17893

Merged

9 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2024

import: call sink.fail() when failed to send message by grpc (#17834) (…

836698b

…#17864) close #17830 Signed-off-by: joccau <zak.zhao@pingcap.cn> Co-authored-by: joccau <zak.zhao@pingcap.cn>

ti-chi-bot bot removed the needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. label Feb 16, 2025

ti-chi-bot pushed a commit to ti-chi-bot/tikv that referenced this pull request Aug 5, 2025

This is an automated cherry-pick of tikv#17834

69f57b7

close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

ti-chi-bot mentioned this pull request Aug 5, 2025

import: call sink.fail() when failed to send message by grpc (#17834) #18789

Merged

9 tasks

ti-chi-bot bot pushed a commit that referenced this pull request Aug 6, 2025

import: call sink.fail() when failed to send message by grpc (#17834) (…

e75745f

…#18789) close #17830 Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn> Co-authored-by: Ruihao Chen <ruihao.chen@pingcap.cn>

Conversation

joccau commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is changed and how it works?

Related changes

Check List

Release note

Uh oh!

ti-chi-bot bot commented Nov 15, 2024

Uh oh!

joccau commented Nov 18, 2024

Uh oh!

joccau commented Nov 18, 2024

Uh oh!

YuJuncen left a comment

Choose a reason for hiding this comment

Uh oh!

YuJuncen Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

joccau Nov 19, 2024

Choose a reason for hiding this comment

Uh oh!

ti-chi-bot commented Nov 19, 2024

Uh oh!

ti-chi-bot commented Nov 19, 2024

Uh oh!

ti-chi-bot commented Nov 19, 2024

Uh oh!

ti-chi-bot commented Nov 19, 2024

Uh oh!

ti-chi-bot commented Nov 25, 2024

Uh oh!

joccau commented Feb 16, 2025

Uh oh!

joechenrh commented Aug 5, 2025

Uh oh!

ti-chi-bot commented Aug 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joccau commented Nov 15, 2024 •

edited

Loading