Skip to content

import: call sink.fail() when failed to send message by grpc (#17834)#17863

Closed
ti-chi-bot wants to merge 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-17834-to-release-6.5
Closed

import: call sink.fail() when failed to send message by grpc (#17834)#17863
ti-chi-bot wants to merge 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-17834-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Nov 19, 2024

This is an automated cherry-pick of #17834

What is changed and how it works?

Issue Number: Close #17830

What's Changed:

  • it should call sink.fail() not sink.close() when failed to send message in cause of RemoteStopped.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 19, 2024
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2024
@ti-chi-bot ti-chi-bot closed this Feb 14, 2025
@YuJuncen YuJuncen reopened this Jun 11, 2025
@YuJuncen
applied patch
0ebf5bc 
Signed-off-by: hillium <yu745514916@live.com>
@YuJuncen YuJuncen force-pushed the cherry-pick-17834-to-release-6.5 branch from 5ee701c to 0ebf5bc Compare June 11, 2025 06:41
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 11, 2025
@YuJuncen
make format
e7c03e9 
Signed-off-by: hillium <yu745514916@live.com>
@ti-chi-bot ti-chi-bot closed this Jun 12, 2025
@YuJuncen YuJuncen reopened this Jun 13, 2025
Benjamin2037
Benjamin2037 approved these changes Jun 13, 2025
View reviewed changes
Copy link

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037
Once this PR has been reviewed and has the lgtm label, please assign pingyu for approval. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 13, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 13, 2025

@ti-chi-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-unit-test e7c03e9 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Jul 16, 2025
@ti-chi-bot ti-chi-bot bot closed this Dec 30, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 30, 2025

This pull request is closed because its related version has closed automatic cherry-picking.
If it's still needed, you can reopen it or just regenerate it using bot,
see:

https://prow.tidb.net/command-help#cherrypick
https://book.prow.tidb.net/#/plugins/cherrypicker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cherry-pick-approved Cherry pick PR approved by release team. contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ti-chi-bot @Benjamin2037 @YuJuncen