import: call sink.fail() when failed to send message by grpc (#17834)#17861
Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-7.1from Nov 20, 2024
Merged
Conversation
close tikv#17830 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
9 tasks
Signed-off-by: joccau <zak.zhao@pingcap.cn>
Contributor
|
//cherry-pick-invite @joccau |
Contributor
|
/cherry-pick-invite @joccau |
Contributor
|
/cherry-pick-invite |
Contributor
|
/test pull-unit-test |
joccau
approved these changes
Nov 20, 2024
Contributor
|
@joccau: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Leavrth
approved these changes
Nov 20, 2024
YuJuncen
approved these changes
Nov 20, 2024
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joccau, Leavrth, YuJuncen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #17834
What is changed and how it works?
Issue Number: Close #17830
What's Changed:
RemoteStopped.Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
Release note