Skip to content

import: call sink.fail() when failed to send message by grpc (#17834)#18789

Merged
ti-chi-bot[bot] merged 7 commits intotikv:release-6.5-20250805-v6.5.12from
ti-chi-bot:cherry-pick-17834-to-release-6.5-20250805-v6.5.12
Aug 6, 2025
Merged

import: call sink.fail() when failed to send message by grpc (#17834)#18789
ti-chi-bot[bot] merged 7 commits intotikv:release-6.5-20250805-v6.5.12from
ti-chi-bot:cherry-pick-17834-to-release-6.5-20250805-v6.5.12

Conversation

@ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Aug 5, 2025

This is an automated cherry-pick of #17834

What is changed and how it works?

Issue Number: Close #17830

What's Changed:

  • it should call sink.fail() not sink.close() when failed to send message in cause of RemoteStopped.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Release note

None

@joccau @ti-chi-bot
This is an automated cherry-pick of tikv#17834
69f57b7 
close tikv#17830

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20250805-v6.5.12 labels Aug 5, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 5, 2025
Merged
9 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 5, 2025
@jebter jebter requested review from Leavrth and YuJuncen August 5, 2025 07:52
@joechenrh
resolve conflict
c6b3b96 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2025
@joechenrh
Copy link

joechenrh commented Aug 5, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
@joechenrh
fixup
10c2014 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@joechenrh
import
d2b4483 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@joechenrh
fix lint
3c3d880 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@ti-chi-bot ti-chi-bot bot added dco-signoff: no Indicates the PR's author has not signed dco. and removed dco-signoff: yes Indicates the PR's author has signed the dco. labels Aug 5, 2025
@joechenrh
update
8f9aebe 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@joechenrh joechenrh force-pushed the cherry-pick-17834-to-release-6.5-20250805-v6.5.12 branch from 3ba9739 to 8f9aebe Compare August 5, 2025 12:13
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. and removed dco-signoff: no Indicates the PR's author has not signed dco. labels Aug 5, 2025
@joechenrh
update
09b5800 
Signed-off-by: Ruihao Chen <ruihao.chen@pingcap.cn>
@joechenrh
Copy link

joechenrh commented Aug 5, 2025

/retest

1 similar comment
@joechenrh
Copy link

joechenrh commented Aug 5, 2025

/retest

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 6, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Leavrth, YuJuncen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 6, 2025
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-08-06 01:42:55.5560282 +0000 UTC m=+405285.698789376: ☑️ agreed by Leavrth.
  • 2025-08-06 01:51:27.854701012 +0000 UTC m=+405797.997462197: ☑️ agreed by YuJuncen.

@ti-chi-bot ti-chi-bot bot merged commit e75745f into tikv:release-6.5-20250805-v6.5.12 Aug 6, 2025
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-17834-to-release-6.5-20250805-v6.5.12 branch August 6, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@YuJuncen YuJuncen YuJuncen approved these changes

+1 more reviewer

@Leavrth Leavrth Leavrth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved contribution This PR is from a community contributor. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5-20250805-v6.5.12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ti-chi-bot @joechenrh @YuJuncen @Leavrth @joccau