Skip to content

refactor: use default batch settings if group_by is used#497

Merged
amitksingh1490 merged 2 commits intomainfrom
fix/485
Oct 15, 2023
Merged

refactor: use default batch settings if group_by is used#497
amitksingh1490 merged 2 commits intomainfrom
fix/485

Conversation

@amitksingh1490
Copy link
Copy Markdown
Collaborator

@amitksingh1490 amitksingh1490 commented Oct 15, 2023

Issue Reference(s):
Fixes #485

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@github-actions github-actions bot added the bug label Oct 15, 2023
@amitksingh1490 amitksingh1490 merged commit 8acc011 into main Oct 15, 2023
@amitksingh1490 amitksingh1490 deleted the fix/485 branch October 15, 2023 14:17
digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 15, 2023
* commit '69814ec785fef5d5cf3d4ba925a4910e0a09715e':
  refactor: use default batch settings if group_by is used (tailcallhq#497)
  refactor: use blueprint server throughout (tailcallhq#495)
  feat: hostname config in server (tailcallhq#493)
  Load YAML & JSON formats via CLI (tailcallhq#467)
  fix(deps): update rust crate regex to 1.10.1 (tailcallhq#491)
  fix(deps): update rust crate async-trait to 0.1.74 (tailcallhq#492)
  feat: support custom-headers (tailcallhq#455)
  fix: n + 1 issue (tailcallhq#487)
  fix: mandatory file path
  refactor: drop key from group by (tailcallhq#484)
  feature: load multiple configs via CLI (tailcallhq#482)
  feat: merge right on config (tailcallhq#476)
  doc: example update
  fix: upstream setting keys should be optional (tailcallhq#474)
  refactor: prerequisite to test multi sdl (tailcallhq#475)
  refactor: use btreeset where duplicates are not allowed (tailcallhq#478)
  fix: info loss in const serialisation (tailcallhq#477)
  feat: support to configure http settings (tailcallhq#388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

If groupby operator is used in config the server.upstream must have batching info

1 participant