Skip to content

feat: support to configure http settings#388

Merged
tusharmath merged 16 commits intotailcallhq:mainfrom
akhill10:feature/configure-http-settings
Oct 12, 2023
Merged

feat: support to configure http settings#388
tusharmath merged 16 commits intotailcallhq:mainfrom
akhill10:feature/configure-http-settings

Conversation

@akhill10
Copy link
Copy Markdown
Contributor

@akhill10 akhill10 commented Sep 30, 2023

Summary:
Support to configure http settings in the server operator

Issue Reference(s):
Fixes #383

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

/claim #383

@algora-pbc algora-pbc bot mentioned this pull request Sep 30, 2023
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7d2584e) 84.98% compared to head (093e309) 82.55%.
Report is 3 commits behind head on main.

❗ Current head 093e309 differs from pull request most recent head f804248. Consider uploading reports for the commit f804248 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #388      +/-   ##
==========================================
- Coverage   84.98%   82.55%   -2.43%     
==========================================
  Files          50       46       -4     
  Lines        4490     4157     -333     
==========================================
- Hits         3816     3432     -384     
- Misses        674      725      +51
Files Coverage Δ
src/http/client.rs 87.23% <100.00%> (+10.09%) ⬆️
src/config/server.rs 59.09% <0.00%> (-8.91%) ⬇️
src/config/config.rs 81.19% <0.00%> (-1.89%) ⬇️

... and 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tusharmath
tusharmath reviewed Sep 30, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 30, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 30, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 30, 2023
View reviewed changes
tusharmath
tusharmath reviewed Sep 30, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 1, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 1, 2023
View reviewed changes
meskill
meskill reviewed Oct 1, 2023
View reviewed changes
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 7, 2023

📌 This PR has been inactive for 2 days.
We value your effort! Please continue and finish your work or provide updates.
If no activity is seen, it will be closed in
5 days. 😢

@github-actions github-actions bot added the Stale label Oct 7, 2023
@github-actions github-actions bot removed the Stale label Oct 9, 2023
meskill
meskill reviewed Oct 9, 2023
View reviewed changes
meskill
meskill reviewed Oct 9, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 11, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 11, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 11, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 11, 2023
View reviewed changes
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Oct 11, 2023

@akhill10 This looks good to go baring a few clean ups and a rebase.

@akhill10
Copy link
Copy Markdown
Contributor Author

akhill10 commented Oct 11, 2023

I think it is good to go.

@tusharmath @meskill Thanks for the reviews and patience with my lame questions as I was new to rust. Learned so many new things during the process. 😄

meskill
meskill suggested changes Oct 11, 2023
View reviewed changes
tusharmath
tusharmath reviewed Oct 12, 2023
View reviewed changes
@tusharmath tusharmath merged commit af179a4 into tailcallhq:main Oct 12, 2023
@tusharmath
Copy link
Copy Markdown
Contributor

tusharmath commented Oct 12, 2023 •
edited
Loading

Thank you once again @akhill10 🙏
This makes writing configurations a lot cleaner !

digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 15, 2023
Merge commit '69814ec785fef5d5cf3d4ba925a4910e0a09715e' into main
6473dd3 
* commit '69814ec785fef5d5cf3d4ba925a4910e0a09715e':
  refactor: use default batch settings if group_by is used (tailcallhq#497)
  refactor: use blueprint server throughout (tailcallhq#495)
  feat: hostname config in server (tailcallhq#493)
  Load YAML & JSON formats via CLI (tailcallhq#467)
  fix(deps): update rust crate regex to 1.10.1 (tailcallhq#491)
  fix(deps): update rust crate async-trait to 0.1.74 (tailcallhq#492)
  feat: support custom-headers (tailcallhq#455)
  fix: n + 1 issue (tailcallhq#487)
  fix: mandatory file path
  refactor: drop key from group by (tailcallhq#484)
  feature: load multiple configs via CLI (tailcallhq#482)
  feat: merge right on config (tailcallhq#476)
  doc: example update
  fix: upstream setting keys should be optional (tailcallhq#474)
  refactor: prerequisite to test multi sdl (tailcallhq#475)
  refactor: use btreeset where duplicates are not allowed (tailcallhq#478)
  fix: info loss in const serialisation (tailcallhq#477)
  feat: support to configure http settings (tailcallhq#388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tusharmath tusharmath tusharmath approved these changes

+1 more reviewer

@meskill meskill meskill requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support to configure http setting via server

3 participants

@akhill10 @tusharmath @meskill