Skip to content

Load YAML & JSON formats via CLI#467

Merged
tusharmath merged 12 commits intotailcallhq:mainfrom
tobihans:feature/yaml-n-json-config
Oct 15, 2023
Merged

Load YAML & JSON formats via CLI#467
tusharmath merged 12 commits intotailcallhq:mainfrom
tobihans:feature/yaml-n-json-config

Conversation

@tobihans
Copy link
Copy Markdown
Contributor

@tobihans tobihans commented Oct 11, 2023

Summary:
This PR adds support for loading YAML & JSON formats via CLI.

Issue Reference(s):
Fixes #439

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

/claim #439

@tusharmath
Copy link
Copy Markdown
Contributor

Do we need these many nulls in the json configs? We made a change in #474 which should have made the Json configs simpler.

@tobihans
Copy link
Copy Markdown
Contributor Author

tobihans commented Oct 13, 2023

Do we need these many nulls in the json configs? We made a change in #474 which should have made the Json configs simpler.

No, not really, I've started cleaning the files. In fact, I generated them from the graphql sample by dumping the loaded config.

@tobihans
Copy link
Copy Markdown
Contributor Author

HI, @tusharmath I've updated the sample configurations now. The PR is ready now. Thanks

@tusharmath tusharmath enabled auto-merge (squash) October 15, 2023 08:02
@tusharmath tusharmath disabled auto-merge October 15, 2023 08:03
@tusharmath tusharmath merged commit eb40888 into tailcallhq:main Oct 15, 2023
@tobihans tobihans deleted the feature/yaml-n-json-config branch October 15, 2023 08:35
digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 15, 2023
* commit '69814ec785fef5d5cf3d4ba925a4910e0a09715e':
  refactor: use default batch settings if group_by is used (tailcallhq#497)
  refactor: use blueprint server throughout (tailcallhq#495)
  feat: hostname config in server (tailcallhq#493)
  Load YAML & JSON formats via CLI (tailcallhq#467)
  fix(deps): update rust crate regex to 1.10.1 (tailcallhq#491)
  fix(deps): update rust crate async-trait to 0.1.74 (tailcallhq#492)
  feat: support custom-headers (tailcallhq#455)
  fix: n + 1 issue (tailcallhq#487)
  fix: mandatory file path
  refactor: drop key from group by (tailcallhq#484)
  feature: load multiple configs via CLI (tailcallhq#482)
  feat: merge right on config (tailcallhq#476)
  doc: example update
  fix: upstream setting keys should be optional (tailcallhq#474)
  refactor: prerequisite to test multi sdl (tailcallhq#475)
  refactor: use btreeset where duplicates are not allowed (tailcallhq#478)
  fix: info loss in const serialisation (tailcallhq#477)
  feat: support to configure http settings (tailcallhq#388)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Load YAML & JSON formats via CLI

2 participants