fix: upstream setting keys should be optional#474
Merged
tusharmath merged 6 commits intomainfrom Oct 13, 2023
Merged
Conversation
tusharmath
reviewed
Oct 13, 2023
src/http/client.rs
Outdated
| .http2_keep_alive_while_idle(upstream.keep_alive_while_idle.unwrap_or(false)) | ||
| .pool_idle_timeout(Some(Duration::from_secs(upstream.pool_idle_timeout.unwrap_or(60)))) | ||
| .pool_max_idle_per_host(upstream.pool_max_idle_per_host.unwrap_or(200)) | ||
| .user_agent(upstream.user_agent.clone().unwrap_or("Tailcall/1.0".to_string())); |
Contributor
There was a problem hiding this comment.
Don't put hard coded values here in the client.
Create methods for each field type to get the default values from the Server.
751d49f to
c3d3ac0
Compare
tusharmath
approved these changes
Oct 13, 2023
tusharmath
approved these changes
Oct 13, 2023
5 tasks
digital-phoenix
pushed a commit
to digital-phoenix/tailcall
that referenced
this pull request
Oct 15, 2023
* commit '69814ec785fef5d5cf3d4ba925a4910e0a09715e': refactor: use default batch settings if group_by is used (tailcallhq#497) refactor: use blueprint server throughout (tailcallhq#495) feat: hostname config in server (tailcallhq#493) Load YAML & JSON formats via CLI (tailcallhq#467) fix(deps): update rust crate regex to 1.10.1 (tailcallhq#491) fix(deps): update rust crate async-trait to 0.1.74 (tailcallhq#492) feat: support custom-headers (tailcallhq#455) fix: n + 1 issue (tailcallhq#487) fix: mandatory file path refactor: drop key from group by (tailcallhq#484) feature: load multiple configs via CLI (tailcallhq#482) feat: merge right on config (tailcallhq#476) doc: example update fix: upstream setting keys should be optional (tailcallhq#474) refactor: prerequisite to test multi sdl (tailcallhq#475) refactor: use btreeset where duplicates are not allowed (tailcallhq#478) fix: info loss in const serialisation (tailcallhq#477) feat: support to configure http settings (tailcallhq#388)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
upstream setting keys should be optional in order to have the capability to merge right else if right don't have upstream values it would pick default always
Build & Testing:
cargo testsuccessfully../lint.shto address and fix linting issues.Checklist: