Skip to content

fix: cache control headers#465

Merged
tusharmath merged 6 commits intomainfrom
fix/459
Oct 11, 2023
Merged

fix: cache control headers#465
tusharmath merged 6 commits intomainfrom
fix/459

Conversation

@amitksingh1490
Copy link
Copy Markdown
Collaborator

@amitksingh1490 amitksingh1490 commented Oct 11, 2023

Issue Reference(s):
Fixes #459

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@github-actions github-actions bot added the bug label Oct 11, 2023
@amitksingh1490
Copy link
Copy Markdown
Collaborator Author

No diff in perf even after enabling cache control headers
image
headers are correctly calculated
image

@tusharmath tusharmath enabled auto-merge (squash) October 11, 2023 14:23
@tusharmath tusharmath merged commit 1774b06 into main Oct 11, 2023
@tusharmath tusharmath deleted the fix/459 branch October 11, 2023 14:26
digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 12, 2023
* commit '234cd25e61d23bd2300a6e15bf0b9b4014a0073c': (25 commits)
  fix: cache control headers (tailcallhq#465)
  chore: update cron freq for PR staleness
  feat: group by endpoint (tailcallhq#451)
  chore: add codecov config
  CI: ignore build when no changes for executable (tailcallhq#454)
  feature: add `tc init` command (tailcallhq#403)
  fix: deploy (tailcallhq#457)
  fix(deps): update rust crate regex to 1.10.0 (tailcallhq#456)
  fix: cargo test fail in Sonoma or later of macos (tailcallhq#453)
  chore: update examples (tailcallhq#452)
  performance: improve for PathString impl for EvaluationContext (tailcallhq#430)
  chore: close stale branches after 2 days
  fix: restricted url for graphiQL (tailcallhq#447)
  performance: minor optimisation (tailcallhq#444)
  chore:update readme (tailcallhq#446)
  chore: update stale bot schedule
  chore: update stale bot message
  chore: use title case for job names in CI (tailcallhq#437)
  chore: remove write permissions
  chore: update stale YML permissions
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken enableCacheControlHeader Feature

2 participants