Skip to content

fix: restricted url for graphiQL#447

Merged
tusharmath merged 2 commits intotailcallhq:mainfrom
wrath-of-god:main
Oct 9, 2023
Merged

fix: restricted url for graphiQL#447
tusharmath merged 2 commits intotailcallhq:mainfrom
wrath-of-god:main

Conversation

@wrath-of-god
Copy link
Copy Markdown
Contributor

@wrath-of-god wrath-of-god commented Oct 8, 2023

Issue Reference(s):
Fixes #349

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

/claim #349

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2023

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (063214c) 85.10% compared to head (e903395) 84.91%.

❗ Current head e903395 differs from pull request most recent head 125ee73. Consider uploading reports for the commit 125ee73 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
- Coverage   85.10%   84.91%   -0.20%     
==========================================
  Files          49       49              
  Lines        4451     4480      +29     
==========================================
+ Hits         3788     3804      +16     
- Misses        663      676      +13     
Files Coverage Δ
src/blueprint/from_config.rs 96.54% <100.00%> (+0.11%) ⬆️
src/config/server.rs 68.00% <ø> (ø)
src/http/server_context.rs 0.00% <0.00%> (ø)
src/http/server.rs 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title Fix: restricted url for graphIQL fix: restricted url for graphIQL Oct 8, 2023
@tusharmath tusharmath changed the title fix: restricted url for graphIQL fix: restricted url for graphiQL Oct 8, 2023
@tusharmath
Copy link
Copy Markdown
Contributor

thanks @wrath-of-god! This looks good 👍

@wrath-of-god
Copy link
Copy Markdown
Contributor Author

@tusharmath Not merged, do need anything?

@tusharmath tusharmath merged commit 455e404 into tailcallhq:main Oct 9, 2023
digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 12, 2023
* commit '234cd25e61d23bd2300a6e15bf0b9b4014a0073c': (25 commits)
  fix: cache control headers (tailcallhq#465)
  chore: update cron freq for PR staleness
  feat: group by endpoint (tailcallhq#451)
  chore: add codecov config
  CI: ignore build when no changes for executable (tailcallhq#454)
  feature: add `tc init` command (tailcallhq#403)
  fix: deploy (tailcallhq#457)
  fix(deps): update rust crate regex to 1.10.0 (tailcallhq#456)
  fix: cargo test fail in Sonoma or later of macos (tailcallhq#453)
  chore: update examples (tailcallhq#452)
  performance: improve for PathString impl for EvaluationContext (tailcallhq#430)
  chore: close stale branches after 2 days
  fix: restricted url for graphiQL (tailcallhq#447)
  performance: minor optimisation (tailcallhq#444)
  chore:update readme (tailcallhq#446)
  chore: update stale bot schedule
  chore: update stale bot message
  chore: use title case for job names in CI (tailcallhq#437)
  chore: remove write permissions
  chore: update stale YML permissions
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throw an error if graphiql uses a restricted route

2 participants