Skip to content

performance: minor optimisation#444

Merged
tusharmath merged 1 commit intomainfrom
perf/optimize-reolver
Oct 9, 2023
Merged

performance: minor optimisation#444
tusharmath merged 1 commit intomainfrom
perf/optimize-reolver

Conversation

@amitksingh1490
Copy link
Copy Markdown
Collaborator

@amitksingh1490 amitksingh1490 commented Oct 8, 2023

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@amitksingh1490 amitksingh1490 added the ci: benchmark Runs benchmarks label Oct 8, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (92985ea) 85.06% compared to head (1cdfafb) 85.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #444      +/-   ##
==========================================
+ Coverage   85.06%   85.10%   +0.03%     
==========================================
  Files          49       49              
  Lines        4447     4451       +4     
==========================================
+ Hits         3783     3788       +5     
+ Misses        664      663       -1     
Files Coverage Δ
src/blueprint/into_schema.rs 97.95% <100.00%> (+1.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath changed the title refactor: minor optimisation performance: minor optimisation Oct 8, 2023
@tusharmath
Copy link
Copy Markdown
Contributor

Please share benchmark numbers — before and after.

@amitksingh1490
Copy link
Copy Markdown
Collaborator Author

Please share benchmark numbers — before and after.

Before
image
After
image

@tusharmath tusharmath merged commit 063214c into main Oct 9, 2023
@tusharmath tusharmath deleted the perf/optimize-reolver branch October 9, 2023 05:29
@tusharmath
Copy link
Copy Markdown
Contributor

Fantastic!

digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 12, 2023
* commit '234cd25e61d23bd2300a6e15bf0b9b4014a0073c': (25 commits)
  fix: cache control headers (tailcallhq#465)
  chore: update cron freq for PR staleness
  feat: group by endpoint (tailcallhq#451)
  chore: add codecov config
  CI: ignore build when no changes for executable (tailcallhq#454)
  feature: add `tc init` command (tailcallhq#403)
  fix: deploy (tailcallhq#457)
  fix(deps): update rust crate regex to 1.10.0 (tailcallhq#456)
  fix: cargo test fail in Sonoma or later of macos (tailcallhq#453)
  chore: update examples (tailcallhq#452)
  performance: improve for PathString impl for EvaluationContext (tailcallhq#430)
  chore: close stale branches after 2 days
  fix: restricted url for graphiQL (tailcallhq#447)
  performance: minor optimisation (tailcallhq#444)
  chore:update readme (tailcallhq#446)
  chore: update stale bot schedule
  chore: update stale bot message
  chore: use title case for job names in CI (tailcallhq#437)
  chore: remove write permissions
  chore: update stale YML permissions
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: benchmark Runs benchmarks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants