Skip to content

fix: cargo test fail in Sonoma or later of macos#453

Merged
tusharmath merged 2 commits intotailcallhq:mainfrom
Yougigun:fix/mac-sonoma-libcurl
Oct 9, 2023
Merged

fix: cargo test fail in Sonoma or later of macos#453
tusharmath merged 2 commits intotailcallhq:mainfrom
Yougigun:fix/mac-sonoma-libcurl

Conversation

@Yougigun
Copy link
Copy Markdown
Contributor

@Yougigun Yougigun commented Oct 9, 2023

Summary:
Briefly describe the changes made in this PR.
potential reason:
alexcrichton/curl-rust#524 (comment)

I followed this sulution.
alexcrichton/curl-rust#524 (comment)

ref:
curl/curl@6ab7e19
rust-lang/cargo#12670
alexcrichton/curl-rust#524

Issue Reference(s):
Fixes #... (Replace "..." with the issue number)

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh to address and fix linting issues.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly (if applicable).
  • I have performed a self-review of my own code.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9c50345) 84.98% compared to head (b962195) 84.98%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #453   +/-   ##
=======================================
  Coverage   84.98%   84.98%           
=======================================
  Files          50       50           
  Lines        4490     4490           
=======================================
  Hits         3816     3816           
  Misses        674      674           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tusharmath tusharmath merged commit 7d2584e into tailcallhq:main Oct 9, 2023
@SomeoneToIgnore
Copy link
Copy Markdown

👋
New curl-sys with the fix had been released recently, so this PR is hopefully not needed anymore.

@tusharmath
Copy link
Copy Markdown
Contributor

@SomeoneToIgnore Ah! What timing. I just merged :D

@SomeoneToIgnore
Copy link
Copy Markdown

Oh, took me some time to fight the hesitation, sorry 🙂
Either way, it's fixed now and you're aware of both ways, which is good.

@Yougigun
Copy link
Copy Markdown
Contributor Author

Yougigun commented Oct 9, 2023

to @SomeoneToIgnore
thanks for the clarification. After updating curl-sys, it seems to work fine now.
to @tusharmath
in my subsequent PR, I will remove the force curl-sys deps, instead, update it in the lock file.

@Yougigun Yougigun deleted the fix/mac-sonoma-libcurl branch October 10, 2023 15:12
digital-phoenix pushed a commit to digital-phoenix/tailcall that referenced this pull request Oct 12, 2023
* commit '234cd25e61d23bd2300a6e15bf0b9b4014a0073c': (25 commits)
  fix: cache control headers (tailcallhq#465)
  chore: update cron freq for PR staleness
  feat: group by endpoint (tailcallhq#451)
  chore: add codecov config
  CI: ignore build when no changes for executable (tailcallhq#454)
  feature: add `tc init` command (tailcallhq#403)
  fix: deploy (tailcallhq#457)
  fix(deps): update rust crate regex to 1.10.0 (tailcallhq#456)
  fix: cargo test fail in Sonoma or later of macos (tailcallhq#453)
  chore: update examples (tailcallhq#452)
  performance: improve for PathString impl for EvaluationContext (tailcallhq#430)
  chore: close stale branches after 2 days
  fix: restricted url for graphiQL (tailcallhq#447)
  performance: minor optimisation (tailcallhq#444)
  chore:update readme (tailcallhq#446)
  chore: update stale bot schedule
  chore: update stale bot message
  chore: use title case for job names in CI (tailcallhq#437)
  chore: remove write permissions
  chore: update stale YML permissions
  ...
@github-actions github-actions bot added the type: chore Routine tasks like conversions, reorganization, and maintenance work. label Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: chore Routine tasks like conversions, reorganization, and maintenance work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants