Merged
Conversation
When using active health checking, hosts are not removed from dynamic clusters if they are still passing health checks. This creates a situation in which hosts might not be removed for a very long time if the sequence is reversed; removal followed by health check failure. This change handles the second case so that any time a host is both removed AND failing active health check, in any order, it will be removed. This has been an issue "forever" but is more obvious when using streaming EDS or very long polling DNS. Fixes #6625 Signed-off-by: Matt Klein <mklein@lyft.com>
* ci: Set up CI with Azure Pipelines Signed-off-by: Lizan Zhou <lizan@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]