-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Upgrading to gRPC 1.17.2 requires ALTS code change #5461
Copy link
Copy link
Closed
Labels
Description
Title: Upgrading to gRPC 1.17.2 requires ALTS code change
Description: While testing some updated dependencies including gRPC 1.17.2, I found that the Envoy ALTS code will need to change to accommodate change in the external dependency gRPC code.
[Relevant Links:]
grpc/grpc@285d4ef#diff-db966a87fffefb50d7a0446f10fbb424 adds a pollset_set to the ALTS TSI handshaker.
Repro steps:
After upgrading the gRPC dependency to 1.17.2 and running tests the following failure is observed:
source/extensions/transport_sockets/alts/config.cc:87:25: error: no matching function for call to 'alts_tsi_handshaker_create'
tsi_result status = alts_tsi_handshaker_create(
^~~~~~~~~~~~~~~~~~~~~~~~~~
external/com_github_grpc_grpc/src/core/tsi/alts/handshaker/alts_tsi_handshaker.h:60:12: note: candidate function not viable: requires 6 arguments, but 5 were provided
tsi_result alts_tsi_handshaker_create(
^
1 error generated.
/cc @lizan who did a lot of the original ALTS work and @htuch
Reactions are currently unavailable