Conversation
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
|
I assume we should wait on this until it's working. /wait |
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Member
Author
|
This should be good to go. @vtbassmatt @mattklein123 |
mattklein123
approved these changes
May 1, 2019
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice, let's see how this goes.
| // this is the cause of flakes. | ||
| static constexpr uint64_t IdleTimeoutMs = 200; | ||
| static constexpr uint64_t RequestTimeoutMs = 100; | ||
| static constexpr uint64_t IdleTimeoutMs = 400; |
Member
There was a problem hiding this comment.
cc @jmarantz can we target these tests for sim time replacement?
jeffpiazza-google
pushed a commit
to jeffpiazza-google/envoy
that referenced
this pull request
May 3, 2019
* ci: Set up CI with Azure Pipelines Signed-off-by: Lizan Zhou <lizan@tetrate.io> Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
From @vtbassmatt's #6720, some script and test fixes to let CI run on Azure Pipelines.
Risk Level: Low
Testing: More CI
Docs Changes: N/A
Release Notes: N/A