Skip to content

build: Fix incompatible_bzl_disallow_load_after_statement#6620

Closed
cmluciano wants to merge 1 commit intoenvoyproxy:masterfrom
cmluciano:cml/bazel025
Closed

build: Fix incompatible_bzl_disallow_load_after_statement#6620
cmluciano wants to merge 1 commit intoenvoyproxy:masterfrom
cmluciano:cml/bazel025

Conversation

@cmluciano
Copy link
Copy Markdown
Member

@cmluciano cmluciano commented Apr 17, 2019 •
edited
Loading

Bazel 0.25.0 errors and requires a flag if load entries are not before custom
functions. The dependency bumps include the latest release of grpc and
rules_foreign_cc that have patches fixing the incompatibility in their own .bzl
files.

Example failure

  'build' options: --verbose_failures --action_env=CXX=clang++-8 --action_env=CC=clang-8 --linkopt=-fuse-ld=lld-8 --experimental_strict_action_env=true  --announce_rc
ERROR: /home/cmluciano/go/src/github.com/envoyproxy/envoy/bazel/envoy_build_system.bzl:378:1: load() statements must be called before any other statement. First non-load() statement appears at /home/cmluciano/go/src/github.com/envoyproxy/envoy/bazel/envoy_build_system.bzl:5:1. Use --incompatible_bzl_disallow_load_after_statement=false to temporarily disable this check.
ERROR: Skipping '//source/exe:envoy-static': error loading package 'source/exe': Extension 'bazel/envoy_build_system.bzl' has errors
WARNING: Target pattern parsing failed.
ERROR: error loading package 'source/exe': Extension 'bazel/envoy_build_system.bzl' has errors
INFO: Elapsed time: 2.713s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)
    currently loading: source/exe
    Fetching @envoy_build_config; Restarting.

Signed-off-by: Christopher M. Luciano cmluciano@us.ibm.com

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:

@moderation
Copy link
Copy Markdown
Contributor

moderation commented Apr 17, 2019

A prior PR to bump gRPC went stale. As per the comments in order to bump gRPC we really need to fix the ALTS code in parallel - #6308 (comment). Older still open issue on this is at #5461

/cc @mrostecki

@cmluciano
Copy link
Copy Markdown
Member Author

cmluciano commented Apr 18, 2019

A prior PR to bump gRPC went stale. As per the comments in order to bump gRPC we really need to fix the ALTS code in parallel - #6308 (comment). Older still open issue on this is at #5461

Thanks for the references @moderation , I'll take a look at those links :)

@cmluciano
Copy link
Copy Markdown
Member Author

cmluciano commented Apr 18, 2019

I still planned on implementing these methods, just want to checkpoint my work for now

@stale
Copy link
Copy Markdown

stale bot commented Apr 26, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Apr 26, 2019
build: Fix incompatible_bzl_disallow_load_after_statement
323e47b 
Bazel 0.25.0 errors and requires a flag if load entries are not before custom
functions. The dependency bumps include the latest release of grpc and
rules_foreign_cc that have patches fixing the incompatibility in their own .bzl
files.

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>

alts: hardcode interested parties and add TODO for configuration

Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
@stale stale bot removed the stale stalebot believes this issue/PR has not been touched recently label Apr 26, 2019
@htuch
Copy link
Copy Markdown
Member

htuch commented Apr 29, 2019

@cmluciano can you update the title of the PR and description in the GitHub UI to reflect what the PR now does?

@htuch
Copy link
Copy Markdown
Member

htuch commented May 1, 2019

The 0.25.0 issue is now acute, I'm going to open a separate PR for this.

@htuch
Copy link
Copy Markdown
Member

htuch commented May 1, 2019

Oh crap, that doesn't work. We need to get this full PR merged ASAP.

@htuch
Copy link
Copy Markdown
Member

htuch commented May 1, 2019

CC @JimmyCYJ any chance you can take a look at this?

htuch added a commit to htuch/envoy that referenced this pull request May 1, 2019
@htuch
build/alts: fixes needed for .bzl and to bump gRPC to 1.20.
f7c0993 
This continues envoyproxy#6620.

See also envoyproxy#6308 and
envoyproxy#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch mentioned this pull request May 1, 2019
Merged
@cmluciano
Copy link
Copy Markdown
Member Author

cmluciano commented May 2, 2019

closing in favor of #6773

@cmluciano cmluciano closed this May 2, 2019
htuch added a commit that referenced this pull request May 2, 2019
@htuch
build/alts: fixes needed for .bzl and to bump gRPC to 1.20. (#6773)
f35eea7 
This continues #6620.

See also #6308 and
#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>
jeffpiazza-google pushed a commit to jeffpiazza-google/envoy that referenced this pull request May 3, 2019
@htuch @jeffpiazza-google
build/alts: fixes needed for .bzl and to bump gRPC to 1.20. (envoypro…
5159a2f 
…xy#6773)

This continues envoyproxy#6620.

See also envoyproxy#6308 and
envoyproxy#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>

Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@htuch htuch

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cmluciano @moderation @htuch