Skip to content

bazel: transport sockets: Update grpc to 1.19.1#6308

Closed
vadorovsky wants to merge 1 commit intoenvoyproxy:masterfrom
vadorovsky:update-grpc
Closed

bazel: transport sockets: Update grpc to 1.19.1#6308
vadorovsky wants to merge 1 commit intoenvoyproxy:masterfrom
vadorovsky:update-grpc

Conversation

@vadorovsky
Copy link
Copy Markdown
Contributor

@vadorovsky vadorovsky commented Mar 18, 2019

Signed-off-by: Michal Rostecki mrostecki@opensuse.org

Description: Update grpc to 1.19.1
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A

@vadorovsky vadorovsky requested a review from htuch as a code owner March 18, 2019 14:48
@moderation
Copy link
Copy Markdown
Contributor

moderation commented Mar 18, 2019

I'd suggest adding a TODO to the ALTS change indicating that ALTS should be updated for the function calls rather than adding nullptr - see #5461

@vadorovsky
bazel: transport sockets: Update grpc to 1.19.1
da68dba 
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: Michal Rostecki <mrostecki@opensuse.org>
@lizan
Copy link
Copy Markdown
Member

lizan commented Mar 18, 2019

I think we need to fix ALTS build issue with latest gRPC, @JimmyCYJ @htuch?

@htuch
Copy link
Copy Markdown
Member

htuch commented Mar 19, 2019

Yep, please do fix ALTS properly for this. Thanks for the contribution @mrostecki.

@htuch htuch added the waiting label Mar 19, 2019
@htuch htuch self-assigned this Mar 19, 2019
@vadorovsky
Copy link
Copy Markdown
Contributor Author

vadorovsky commented Mar 19, 2019

@htuch @moderation Thanks for pointing that out! I will fix ALTS properly.

@stale
Copy link
Copy Markdown

stale bot commented Mar 26, 2019

This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot added the stale stalebot believes this issue/PR has not been touched recently label Mar 26, 2019
@stale
Copy link
Copy Markdown

stale bot commented Apr 2, 2019

This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@stale stale bot closed this Apr 2, 2019
@moderation moderation mentioned this pull request Apr 17, 2019
Closed
htuch added a commit to htuch/envoy that referenced this pull request May 1, 2019
@htuch
build/alts: fixes needed for .bzl and to bump gRPC to 1.20.
f7c0993 
This continues envoyproxy#6620.

See also envoyproxy#6308 and
envoyproxy#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch mentioned this pull request May 1, 2019
Merged
htuch added a commit that referenced this pull request May 2, 2019
@htuch
build/alts: fixes needed for .bzl and to bump gRPC to 1.20. (#6773)
f35eea7 
This continues #6620.

See also #6308 and
#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>
jeffpiazza-google pushed a commit to jeffpiazza-google/envoy that referenced this pull request May 3, 2019
@htuch @jeffpiazza-google
build/alts: fixes needed for .bzl and to bump gRPC to 1.20. (envoypro…
5159a2f 
…xy#6773)

This continues envoyproxy#6620.

See also envoyproxy#6308 and
envoyproxy#5461.

Risk level: Low
Testing: Existing tests

Signed-off-by: Harvey Tuch <htuch@google.com>

Signed-off-by: Jeff Piazza <jeffpiazza@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@htuch htuch Awaiting requested review from htuch

Assignees

@htuch htuch

Labels

stale stalebot believes this issue/PR has not been touched recently waiting

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vadorovsky @moderation @lizan @htuch