-
Notifications
You must be signed in to change notification settings - Fork 4k
Update dataframe column properties on frontend #6554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontend/src/components/widgets/DataFrame/hooks/useColumnLoader.ts
Outdated
Show resolved
Hide resolved
frontend/src/components/widgets/DataFrame/hooks/useDataEditor.ts
Outdated
Show resolved
Hide resolved
willhuang1997
approved these changes
Apr 24, 2023
Contributor
willhuang1997
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 25, 2023
* develop: Decouple MetricsManager from AppNode (streamlit#6557) Fix top padding on sidebar when embed is true (streamlit#6565) Add support for cell and column header tooltips in the dataframe component (streamlit#6561) Update dataframe column properties on frontend (streamlit#6554) Show warning for unsafe integer cells in `st.dataframe` (streamlit#6549) Add icon for editable columns in `st.data_editor` (streamlit#6550) Unify missing values to None in the returned datastructure by `st.data_editor`. (streamlit#6544) Clean up and reorganize element tree module (streamlit#6522) ESLint: use `--cache` flag (30x speedup!) (streamlit#6555) Replace `st.connection` with `st.experimental_connection` in docstring examples (streamlit#6553) Improve editing on touch devices for `st.data_editor` (streamlit#6548) Move pandas styler logic to dedicated module (streamlit#6543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
This PR adds and updates some internal column properties (
BaseColumnProps) as a preparation for the column config feature:add
name: this is the column name from the original data. We need this in addition to thetitlesince the title is something that can be changed by the user.rename
columnTypeMetadatatocolumnTypeOptionsadd
defaultValueand use it inuseDataEditorwhen a user adds a new row.add
isRequiredand use it inuseDataEditorto prevent cell deletions and in BooleanColumn to not show the empty option.Introduce
small,medium,largeoptions for column width instead of a numerical value.Update the user-provided
ColumnConfigPropsto reflect the changes.Update the
ColumnConfigin backend to reflect the changes.What kind of change does this PR introduce?
🧪 Testing Done
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.