Show warning for unsafe integer cells in st.dataframe
#6549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st.dataframest.dataframe
| "⚠️ 1234567898765432123\n\nThe value is larger than the maximum supported integer values in number columns (2^53).\n" | ||
| ) | ||
|
|
||
| const safeCell = mockColumn.getCell("1234567898765432") |
Contributor
There was a problem hiding this comment.
Should this test be a separate test?
I would expect this to be a separate test or the description to be longer. I prefer a separate test.
Collaborator
Author
There was a problem hiding this comment.
Good point 👍 I will extract this as separate test
willhuang1997
approved these changes
Apr 24, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 25, 2023
* develop: Decouple MetricsManager from AppNode (streamlit#6557) Fix top padding on sidebar when embed is true (streamlit#6565) Add support for cell and column header tooltips in the dataframe component (streamlit#6561) Update dataframe column properties on frontend (streamlit#6554) Show warning for unsafe integer cells in `st.dataframe` (streamlit#6549) Add icon for editable columns in `st.data_editor` (streamlit#6550) Unify missing values to None in the returned datastructure by `st.data_editor`. (streamlit#6544) Clean up and reorganize element tree module (streamlit#6522) ESLint: use `--cache` flag (30x speedup!) (streamlit#6555) Replace `st.connection` with `st.experimental_connection` in docstring examples (streamlit#6553) Improve editing on touch devices for `st.data_editor` (streamlit#6548) Move pandas styler logic to dedicated module (streamlit#6543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
The number column of
st.dataframeandst.data_editoris not able to handle numbers larger than2^53as explained in this issue: #6311Unfortunately, we cannot easily fix this since we rely on
Numberin Javascript (which has this limit) in the number column implementation. Therefore, in this case, we are showing a warning to make it more obvious that the shown value cannot handle as a number value. However, we expect that this is only an issue in very very few situations since it is unlikely that users are using such big numbers. Another workaround for users is to convert the column to string, which will be able to show all numbers, regardless of size correctly.What kind of change does this PR introduce?
🧪 Testing Done
🧠 Description of Changes
Revised:
Current:
The int64 value of 1009513310189256287 is shown as 1009513310189256300. This is caused by JavaScript not supporting these large integers with Number (see here, max is 9007199254740991).
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.