Skip to content

Conversation

@snehankekre
Copy link
Contributor

📚 Context

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe: Doc improvement request

🧠 Description of Changes

  • Replaces st.connection with st.experimental_connection in connection factory docstring examples

    • This is a breaking API change
    • This is a visible (user-facing) change

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@snehankekre snehankekre added the security-assessment-completed Security assessment has been completed for PR label Apr 24, 2023
@snehankekre snehankekre added area:experimental feature:connections Related to `st.connection` and connections module labels Apr 24, 2023
@snehankekre
Copy link
Contributor Author

Note to reviewers: a docstring change shouldn't be breaking the st.map e2e test. There might be flakiness there unrelated to changes in this PR.

@vdonato
Copy link
Collaborator

vdonato commented Apr 24, 2023

Thanks for catching this @snehankekre!

Heads up that I think we'll need to cherry-pick this onto the release @sfc-gh-jcarroll / @kmcgrady, but it should be trivial since it's a docs-only change.

@vdonato vdonato merged commit 8225f39 into develop Apr 24, 2023
@vdonato vdonato deleted the connection-to-experimental-connection branch April 24, 2023 18:40
tconkling added a commit to tconkling/streamlit that referenced this pull request Apr 25, 2023
* develop:
  Decouple MetricsManager from AppNode (streamlit#6557)
  Fix top padding on sidebar when embed is true (streamlit#6565)
  Add support for cell and column header tooltips in the dataframe component (streamlit#6561)
  Update dataframe column properties on frontend (streamlit#6554)
  Show warning for unsafe integer cells in `st.dataframe` (streamlit#6549)
  Add icon for editable columns in `st.data_editor` (streamlit#6550)
  Unify missing values to None in the returned datastructure by `st.data_editor`.  (streamlit#6544)
  Clean up and reorganize element tree module (streamlit#6522)
  ESLint: use `--cache` flag (30x speedup!) (streamlit#6555)
  Replace `st.connection` with `st.experimental_connection` in docstring examples (streamlit#6553)
  Improve editing on touch devices for `st.data_editor` (streamlit#6548)
  Move pandas styler logic to dedicated module (streamlit#6543)
tconkling pushed a commit that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature:connections Related to `st.connection` and connections module security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants