Clean up and reorganize element tree module #6522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class Caption(Markdown): | ||
| def __init__(self, proto: MarkdownProto, root: ElementTree): | ||
| super().__init__(proto, root) | ||
| self.type = "caption" |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| class Divider(Markdown): | ||
| def __init__(self, proto: MarkdownProto, root: ElementTree): | ||
| super().__init__(proto, root) | ||
| self.type = "divider" |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
| class Latex(Markdown): | ||
| def __init__(self, proto: MarkdownProto, root: ElementTree): | ||
| super().__init__(proto, root) | ||
| self.type = "latex" |
Check warning
Code scanning / CodeQL
Overwriting attribute in super-class or sub-class
willhuang1997
approved these changes
Apr 20, 2023
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Apr 25, 2023
* develop: Decouple MetricsManager from AppNode (streamlit#6557) Fix top padding on sidebar when embed is true (streamlit#6565) Add support for cell and column header tooltips in the dataframe component (streamlit#6561) Update dataframe column properties on frontend (streamlit#6554) Show warning for unsafe integer cells in `st.dataframe` (streamlit#6549) Add icon for editable columns in `st.data_editor` (streamlit#6550) Unify missing values to None in the returned datastructure by `st.data_editor`. (streamlit#6544) Clean up and reorganize element tree module (streamlit#6522) ESLint: use `--cache` flag (30x speedup!) (streamlit#6555) Replace `st.connection` with `st.experimental_connection` in docstring examples (streamlit#6553) Improve editing on touch devices for `st.data_editor` (streamlit#6548) Move pandas styler logic to dedicated module (streamlit#6543)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added implementations to the file pretty haphazardly, so now that widgets are done I wanted to both make it alphabetical, and remove some redundancy in the implementations.
I recommend looking at each commit sequentially, since they are very focused and self-contained but the full set of changes is much harder to follow.