StreamlitEndpoints.buildMediaURL #6366
Merged
+147
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tconkling
commented
Mar 24, 2023
| host: "streamlit.mock", | ||
| port: 80, | ||
| basePath: "", | ||
| basePath: "mock/base/path", |
Contributor
Author
There was a problem hiding this comment.
I updated this entire test suite to use a non-empty basePath to ensure we're actually testing against it
tconkling
commented
Mar 24, 2023
Comment on lines
+32
to
+35
| const MEDIA_ENDPOINT = "/media" | ||
| const UPLOAD_FILE_ENDPOINT = "/_stcore/upload_file" | ||
| const COMPONENT_ENDPOINT_BASE = "/component" | ||
| const FORWARD_MSG_CACHE_ENDPOINT = "/_stcore/message" |
Contributor
Author
There was a problem hiding this comment.
I pulled all these to the top level of the file for readability
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 27, 2023
* develop: StreamlitEndpoints.buildMediaURL (streamlit#6366) Set a default for RuntimeConfig.cache_storage_manager (streamlit#6361) FullScreenWrapper: add a type declaration for react context usage (streamlit#6364) Improve st.help (and st.write's usage of st.help!) (streamlit#5857) Fix regression with query_params (streamlit#6348) Have util.calc_md5 also take bytes (streamlit#6358) Improve deploy button (streamlit#6223) Return whether a secrets.toml file is successfully parsed (streamlit#6333) Add `.webp` to list of safe static file extensions (streamlit#6331) AppContext docstrings (streamlit#6353) fix: upgrade command-line-args from 5.0.2 to 5.2.1 (streamlit#6258) fix: upgrade flatbuffers from 1.11.0 to 1.12.0 (streamlit#6259) sendMessageToHost: no longer a global function (streamlit#6345) Tweak no-else-return config options (streamlit#6343) Allow users to set a secrets.toml file in their home directory (streamlit#6230) Add support for number and boolean types in categorical columns (streamlit#6248) Add support for period type in st.table and st.dataframe (streamlit#5429) Add ability to turn off anchors (streamlit#6158) Add sqlalchemy mypy types to test-requirements.txt (streamlit#6329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
StreamlitEndpoints.buildMediaURLand updatesAudio.tsxto use it. (This is the first of several PRs that will update existing components to use this new API.)buildMediaUri, that takes aBaseUriPartsinstance and handles constructing Streamlit-relative URLs for media files. It has some assumptions about how Streamlit endpoints are named that we want to move away from for the StreamlitView project.StreamlitEndpoints.buildMediaURLto the StreamlitEndpoints interface, and replicates the current implementation inDefaultStreamlitEndpoints.Audio.tsxis updated to use the interface-ized version of the function.