Skip to content

Conversation

@tconkling
Copy link
Contributor

@tconkling tconkling commented Mar 21, 2023

  • Added docstrings for each AppContext property
  • Removed unused AppContext.layout property
  • Moved AppContext into AppContext.tsx, from AppContext/index.tsx

@tconkling tconkling added the security-assessment-completed Security assessment has been completed for PR label Mar 21, 2023
@tconkling tconkling marked this pull request as ready for review March 21, 2023 23:45
@tconkling tconkling requested a review from willhuang1997 March 21, 2023 23:47
activeTheme: ThemeConfig

/**
* Set the app's active theme locall, and send it the app's host (if any).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Set the app's active theme local and send it the app's host (if any).

@tconkling tconkling merged commit 5bbfee3 into streamlit:develop Mar 22, 2023
@tconkling tconkling deleted the tim/AppContextDocs branch March 22, 2023 01:38
tconkling added a commit to tconkling/streamlit that referenced this pull request Mar 27, 2023
* develop:
  StreamlitEndpoints.buildMediaURL (streamlit#6366)
  Set a default for RuntimeConfig.cache_storage_manager (streamlit#6361)
  FullScreenWrapper: add a type declaration for react context usage (streamlit#6364)
  Improve st.help (and st.write's usage of st.help!) (streamlit#5857)
  Fix regression with query_params  (streamlit#6348)
  Have util.calc_md5 also take bytes (streamlit#6358)
  Improve deploy button (streamlit#6223)
  Return whether a secrets.toml file is successfully parsed (streamlit#6333)
  Add `.webp` to list of safe static file extensions (streamlit#6331)
  AppContext docstrings (streamlit#6353)
  fix: upgrade command-line-args from 5.0.2 to 5.2.1 (streamlit#6258)
  fix: upgrade flatbuffers from 1.11.0 to 1.12.0 (streamlit#6259)
  sendMessageToHost: no longer a global function (streamlit#6345)
  Tweak no-else-return config options (streamlit#6343)
  Allow users to set a secrets.toml file in their home directory (streamlit#6230)
  Add support for number and boolean types in categorical columns (streamlit#6248)
  Add support for period type in st.table and st.dataframe (streamlit#5429)
  Add ability to turn off anchors (streamlit#6158)
  Add sqlalchemy mypy types to test-requirements.txt (streamlit#6329)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants