Add ability to turn off anchors #6158
Conversation
sfc-gh-tszerszen
left a comment
There was a problem hiding this comment.
Just a few questions, generally LGTM 👍
| supported colors: blue, green, orange, red, violet. | ||
| anchor : str | ||
| anchor : str or False |
There was a problem hiding this comment.
Will empty string or None be interpreted as anchor=False? should it? In my opinion it should, otherwise LGTM 👍 then maybe we should do anchor : str or None or False and empty sting is interpreted as None / False?
There was a problem hiding this comment.
None means that the value should be generated automatically. It is covered by docstring. We cannot change it, because it will be a breaking change.
If omitted, it generates an anchor using the body.
proto/streamlit/proto/Heading.proto
Outdated
|
|
||
| string anchor = 2; | ||
| string body = 3; | ||
| bool hide_anchor = 4; |
There was a problem hiding this comment.
NIT: I don't mind having more Proto at all, I guess it would be cleaner if we could just hide the anchor when anchor is empty then we don't show it
There was a problem hiding this comment.
an empty anchor field has its existing meaning, so we can't re-use it.
snehankekre
left a comment
There was a problem hiding this comment.
Approving the docstring changes that LGTM 👍
sfc-gh-mnowotka
left a comment
There was a problem hiding this comment.
Left 3 comments.
74801f9 to
6b01af8
Compare
6b01af8 to
fb1939b
Compare
* develop: StreamlitEndpoints.buildMediaURL (streamlit#6366) Set a default for RuntimeConfig.cache_storage_manager (streamlit#6361) FullScreenWrapper: add a type declaration for react context usage (streamlit#6364) Improve st.help (and st.write's usage of st.help!) (streamlit#5857) Fix regression with query_params (streamlit#6348) Have util.calc_md5 also take bytes (streamlit#6358) Improve deploy button (streamlit#6223) Return whether a secrets.toml file is successfully parsed (streamlit#6333) Add `.webp` to list of safe static file extensions (streamlit#6331) AppContext docstrings (streamlit#6353) fix: upgrade command-line-args from 5.0.2 to 5.2.1 (streamlit#6258) fix: upgrade flatbuffers from 1.11.0 to 1.12.0 (streamlit#6259) sendMessageToHost: no longer a global function (streamlit#6345) Tweak no-else-return config options (streamlit#6343) Allow users to set a secrets.toml file in their home directory (streamlit#6230) Add support for number and boolean types in categorical columns (streamlit#6248) Add support for period type in st.table and st.dataframe (streamlit#5429) Add ability to turn off anchors (streamlit#6158) Add sqlalchemy mypy types to test-requirements.txt (streamlit#6329)
📚 Context
Please describe the project or issue background here
Header elements have anchors that show up when hovering. Sometimes they are visually annoying (e.g. on component.streamlit.app). We already have a parameter anchor – let’s just allow anchor=False to turn them off.
What kind of change does this PR introduce?
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.