sendMessageToHost: no longer a global function #6345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* develop: Tweak no-else-return config options (streamlit#6343) Allow users to set a secrets.toml file in their home directory (streamlit#6230) Add support for number and boolean types in categorical columns (streamlit#6248)
tconkling
commented
Mar 20, 2023
| beforeEach(() => (originalLocation = window.location)) | ||
| afterEach(() => (window.location = originalLocation)) | ||
|
|
||
| it("sends UPDATE_HASH message to host", () => { |
Contributor
Author
There was a problem hiding this comment.
This test was missing before
tconkling
commented
Mar 20, 2023
| expect(getFaviconHref()).toBe(PIZZA_TWEMOJI_URL) | ||
| }) | ||
|
|
||
| it("sends SET_PAGE_FAVICON message to host", () => { |
Contributor
Author
There was a problem hiding this comment.
this test was also missing before
willhuang1997
approved these changes
Mar 21, 2023
Contributor
willhuang1997
left a comment
There was a problem hiding this comment.
LGTM. thanks for adding the missing test :)
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Mar 27, 2023
* develop: StreamlitEndpoints.buildMediaURL (streamlit#6366) Set a default for RuntimeConfig.cache_storage_manager (streamlit#6361) FullScreenWrapper: add a type declaration for react context usage (streamlit#6364) Improve st.help (and st.write's usage of st.help!) (streamlit#5857) Fix regression with query_params (streamlit#6348) Have util.calc_md5 also take bytes (streamlit#6358) Improve deploy button (streamlit#6223) Return whether a secrets.toml file is successfully parsed (streamlit#6333) Add `.webp` to list of safe static file extensions (streamlit#6331) AppContext docstrings (streamlit#6353) fix: upgrade command-line-args from 5.0.2 to 5.2.1 (streamlit#6258) fix: upgrade flatbuffers from 1.11.0 to 1.12.0 (streamlit#6259) sendMessageToHost: no longer a global function (streamlit#6345) Tweak no-else-return config options (streamlit#6343) Allow users to set a secrets.toml file in their home directory (streamlit#6230) Add support for number and boolean types in categorical columns (streamlit#6248) Add support for period type in st.table and st.dataframe (streamlit#5429) Add ability to turn off anchors (streamlit#6158) Add sqlalchemy mypy types to test-requirements.txt (streamlit#6329)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendMessageToHostdelivers "guest to host" messages to the Streamlit app's parent iframe (if one exists). It's currently implemented as a global function. This PR removes the global function; callers must now take the function as a property.(
withHostCommunicationHOCalready passes the function to its wrapped component, so this isn't a huge change.)