Skip to content

Conversation

@kmcgrady
Copy link
Collaborator

@kmcgrady kmcgrady commented Dec 1, 2022

No description provided.

tvst and others added 11 commits November 14, 2022 11:40
Turn off altair theme for now for a silent release.
* Fix camera_input flaky test (hopefully)
Update the component-template ts versions to 4.2, which can parse the types that are encountered during build
Right now, the current implementation of st.plotly_chart(...,theme="streamlit") doesn't allow overriding properties within a graph; it will always applies streamlit theme to that graph. As a result, it's not very usable for a developer who wants to override the colors or other such specific things but also get Streamlit's layout changes. As a result, this PR is for that.
This is mainly refactoring and allowing theme="streamlit" to be the default. We are using Plotly's inbuilt theme object and then passing that to the frontend because we want to swap the colors when the settings are swapped from light to dark and the backend has no knowledge of that.

Demo app: https://streamlit-feature-demos-plotlystreamlitstreamlit-app-jjumlv.streamlit.app
@kmcgrady kmcgrady added the security-assessment-completed Security assessment has been completed for PR label Dec 1, 2022
@kmcgrady kmcgrady merged commit ba503da into develop Dec 1, 2022
tconkling added a commit that referenced this pull request Dec 2, 2022
* develop:
  Fix #5661, update react-webcam dependency (#5711)
  metrics_util_test.test_public_api_commands: minor cleanup (#5801)
  Release 1.15.2 (#5800)
tconkling added a commit to tconkling/streamlit that referenced this pull request Dec 2, 2022
# By Karen Javadyan (1) and others
# Via GitHub (1) and Tim Conkling (1)
* feature/ReleaseCacheV2:
  Fix streamlit#5661, update react-webcam dependency (streamlit#5711)
  metrics_util_test.test_public_api_commands: minor cleanup (streamlit#5801)
  Release 1.15.2 (streamlit#5800)

# Conflicts:
#	lib/tests/streamlit/runtime/metrics_util_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants