Skip to content

metrics_util_test tweaks #5801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tconkling merged 1 commit into from
Dec 2, 2022
Merged

metrics_util_test tweaks #5801

tconkling merged 1 commit into from
Dec 2, 2022

Conversation

@tconkling
Copy link
Contributor

@tconkling tconkling commented Dec 1, 2022

Small modifications to metrics_util_test.test_public_api_commands for clarity:

  • Sort our list of public_api_names, so that we iterate it deterministically (I have a branch that introduces a couple metrics naming errors, and i was getting different errors on different runs)
  • Add a few comments and name changes where things confused me
  • Add a custom explanation message to the assertIn call, to help explain the context of failures

@tconkling tconkling requested a review from lukasmasuch December 1, 2022 23:42
@tconkling tconkling force-pushed the tim/MetricsUtilTestTweak branch from bb3ff42 to 03ecc4b Compare December 1, 2022 23:43
@tconkling tconkling added the security-assessment-completed Security assessment has been completed for PR label Dec 1, 2022
lukasmasuch
lukasmasuch approved these changes Dec 2, 2022
View reviewed changes
Copy link
Collaborator

@lukasmasuch lukasmasuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tconkling tconkling merged commit a9e130b into streamlit:develop Dec 2, 2022
@tconkling tconkling deleted the tim/MetricsUtilTestTweak branch December 2, 2022 01:21
tconkling added a commit that referenced this pull request Dec 2, 2022
@tconkling
Merge branch 'develop' into feature/ReleaseCacheV2
5b3e539 
* develop:
  Fix #5661, update react-webcam dependency (#5711)
  metrics_util_test.test_public_api_commands: minor cleanup (#5801)
  Release 1.15.2 (#5800)
tconkling added a commit to tconkling/streamlit that referenced this pull request Dec 2, 2022
@tconkling
Merge branch 'feature/ReleaseCacheV2' into tim/ExperimentalDeprecations
abbe15f 
# By Karen Javadyan (1) and others
# Via GitHub (1) and Tim Conkling (1)
* feature/ReleaseCacheV2:
  Fix streamlit#5661, update react-webcam dependency (streamlit#5711)
  metrics_util_test.test_public_api_commands: minor cleanup (streamlit#5801)
  Release 1.15.2 (streamlit#5800)

# Conflicts:
#	lib/tests/streamlit/runtime/metrics_util_test.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukasmasuch lukasmasuch lukasmasuch approved these changes

Assignees

No one assigned

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tconkling @lukasmasuch