Fix #5661, update react-webcam dependency #5711
Merged
+31
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix camera jitter bug
b6216b9 to
692e6e4
Compare
vdonato
approved these changes
Nov 30, 2022
Collaborator
vdonato
left a comment
There was a problem hiding this comment.
LGTM
It'd be nice to figure out a way to unit test this if possible, but I'm not entirely sure if there's a way of doing so that's not a ton of unwarranted effort, so I wouldn't try too hard to figure something out.
frontend/src/components/widgets/CameraInput/WebcamComponent.tsx
Outdated
Show resolved
Hide resolved
…bouncedCallback`
Collaborator
Author
Yes, I agree, for this specific case (working with browser API to access the camera and event for browser resize) it is really tricky to come up with unit tests. |
tconkling
added a commit
that referenced
this pull request
Dec 2, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Dec 2, 2022
# By Karen Javadyan (1) and others # Via GitHub (1) and Tim Conkling (1) * feature/ReleaseCacheV2: Fix streamlit#5661, update react-webcam dependency (streamlit#5711) metrics_util_test.test_public_api_commands: minor cleanup (streamlit#5801) Release 1.15.2 (streamlit#5800) # Conflicts: # lib/tests/streamlit/runtime/metrics_util_test.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
We request video stream from a browser using the
widthprop, but it could have been changed very often (when we resize the window), which was leading to spamming the system queue of requests to the web camera. As a solution, we use debouncingwidthchange handler and only request new video streams with constraints based on the width that stabilized after window resizes.What kind of change does this PR introduce?
🧠 Description of Changes
Add bullet points summarizing your changes here
Revised:
Insert screenshot of your updated UI/code here
Current:
Insert screenshot of existing UI/code here
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.