Turn off theme for now #5701
Merged
Turn off theme for now #5701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
tconkling
approved these changes
Nov 15, 2022
Contributor
tconkling
left a comment
There was a problem hiding this comment.
(Per William, this PR will be reverted after we push out an internal release to fix some issues.)
Comment on lines
70
to
84
| @patch.object(DeltaGenerator, "_legacy_dataframe") | ||
| @patch.object(DeltaGenerator, "_arrow_dataframe") | ||
| @patch_config_options({"global.dataFrameSerialization": "arrow"}) | ||
| def test_arrow_dataframe_with_pyspark_dataframe( | ||
| self, arrow_dataframe, legacy_dataframe | ||
| ): | ||
| pyspark_dataframe = ( | ||
| pyspark_mocks.create_pyspark_dataframe_with_mocked_personal_data() | ||
| ) | ||
| streamlit.dataframe(pyspark_dataframe, 100, 200) | ||
| legacy_dataframe.assert_not_called() | ||
| arrow_dataframe.assert_called_once_with( | ||
| pyspark_dataframe, 100, 200, use_container_width=False | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
Why is this test removed?
mayagbarnes
pushed a commit
that referenced
this pull request
Nov 18, 2022
Turn off altair theme for now for a silent release.
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 18, 2022
* develop: (25 commits) Fix CORS acronym in docstring (streamlit#5727) Add integration tests for Snowpark (streamlit#5543) Release/1.15.0 (streamlit#5720) Add audit_frontend_dependencies script to CODEOWNERS (streamlit#5708) Add label_visibility option for st.checkbox (streamlit#5705) Display existing column names in st.map exception and make st.map work with capital letters (streamlit#5679) Plotly Customization (streamlit#5681) Turn off theme for now (streamlit#5701) Add all vendored code to `make notices` (streamlit#5704) Audit frontend licenses (streamlit#5664) Surround labels in quotes (streamlit#5703) Add info about voting on features (streamlit#5660) Update issue labeling scheme to adopt new standards (streamlit#5702) Cached media (audio+video) replay (streamlit#5695) Fix docstring line wrap (streamlit#5698) Use specialized assertion functions (streamlit#5680) Release 1.14.1 (streamlit#5693) Image replay in cached functions (streamlit#5675) Add docstrings for `experimental_allow_widgets` (streamlit#5670) Remove `st.write` from `CachedStFunctionWarning` (streamlit#5669) ...
kmcgrady
pushed a commit
that referenced
this pull request
Nov 30, 2022
Turn off altair theme for now for a silent release.
willhuang1997
added a commit
to willhuang1997/streamlit
that referenced
this pull request
Dec 1, 2022
This reverts commit 1ae3fac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn off altair theme for now for a silent release.