Add label_visibility option for st.checkbox #5705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayagbarnes
reviewed
Nov 16, 2022
| c = self.get_delta_from_queue().new_element.checkbox | ||
| self.assertEqual(c.label, "the label") | ||
| self.assertEqual(c.label_visibility.value, proto_value) | ||
|
|
Collaborator
There was a problem hiding this comment.
Would it be possible to write a test for the 3rd scenario where label="" and the warning is raised?
mayagbarnes
reviewed
Nov 16, 2022
| checked={this.state.value} | ||
| disabled={disabled} | ||
| onChange={this.onChange} | ||
| aria-label={element.label} |
mayagbarnes
approved these changes
Nov 16, 2022
vdonato
approved these changes
Nov 17, 2022
tconkling
added a commit
to tconkling/streamlit
that referenced
this pull request
Nov 18, 2022
* develop: (25 commits) Fix CORS acronym in docstring (streamlit#5727) Add integration tests for Snowpark (streamlit#5543) Release/1.15.0 (streamlit#5720) Add audit_frontend_dependencies script to CODEOWNERS (streamlit#5708) Add label_visibility option for st.checkbox (streamlit#5705) Display existing column names in st.map exception and make st.map work with capital letters (streamlit#5679) Plotly Customization (streamlit#5681) Turn off theme for now (streamlit#5701) Add all vendored code to `make notices` (streamlit#5704) Audit frontend licenses (streamlit#5664) Surround labels in quotes (streamlit#5703) Add info about voting on features (streamlit#5660) Update issue labeling scheme to adopt new standards (streamlit#5702) Cached media (audio+video) replay (streamlit#5695) Fix docstring line wrap (streamlit#5698) Use specialized assertion functions (streamlit#5680) Release 1.14.1 (streamlit#5693) Image replay in cached functions (streamlit#5675) Add docstrings for `experimental_allow_widgets` (streamlit#5670) Remove `st.write` from `CachedStFunctionWarning` (streamlit#5669) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Context
Add the
label_visibilitykeyword-only parameter tost.checkboxwidget, to be consistent with other widgets.What kind of change does this PR introduce?
🧠 Description of Changes
Please note that unlike other widgets
st.checkboxdoesn't useWidgetLabelcomponent for displaying widgets. That's why we have a bit different implementation for this case on the frontend side. Backend changes are identical to other widgets.Visible:
Hidden:
Collapsed:
🧪 Testing Done
🌐 References
Does this depend on other work, documents, or tickets?
Contribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.