Skip to content

Conversation

@sfc-gh-kbregula
Copy link
Contributor

📚 Context

Please describe the project or issue background here

  • What kind of change does this PR introduce?

    • Bugfix
    • Feature
    • Refactoring
    • Other, please describe:

🧠 Description of Changes

  • Add bullet points summarizing your changes here

    • This is a breaking API change
    • This is a visible (user-facing) change

Revised:

Insert screenshot of your updated UI/code here

Current:

Insert screenshot of existing UI/code here

🧪 Testing Done

  • Screenshots included
  • Added/Updated unit tests
  • Added/Updated e2e tests

🌐 References

Does this depend on other work, documents, or tickets?

  • Issue: Closes #XXXX

Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@sfc-gh-tszerszen sfc-gh-tszerszen self-requested a review October 14, 2022 07:04
@sfc-gh-tszerszen
Copy link
Contributor

Strongly support this 👍 can we create some MVP from this and merge it?

@sfc-gh-kbregula sfc-gh-kbregula force-pushed the sfc-gh-kbregula-snowflake-ci branch from 63469f3 to ef14516 Compare October 26, 2022 19:30
@sfc-gh-kbregula sfc-gh-kbregula force-pushed the sfc-gh-kbregula-snowflake-ci branch 3 times, most recently from 6b2e82c to d3da19f Compare November 8, 2022 19:15
@sfc-gh-kbregula sfc-gh-kbregula force-pushed the sfc-gh-kbregula-snowflake-ci branch from d3da19f to 9442b86 Compare November 9, 2022 23:23
@sfc-gh-kbregula sfc-gh-kbregula changed the title Add Snowflake tests setup Add integration tests for Snowpark Nov 9, 2022
Copy link
Contributor

@sfc-gh-tszerszen sfc-gh-tszerszen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@sfc-gh-kbregula sfc-gh-kbregula marked this pull request as ready for review November 14, 2022 13:13
@vdonato
Copy link
Collaborator

vdonato commented Nov 17, 2022

Hm, looks like this may still need a CODEOWNERS review for the changes to lib/setup.py (although I'm being added to the CODEOWNERS for that file in #5708, so this should be mergeable after that PR is checked in).

@sfc-gh-kbregula sfc-gh-kbregula merged commit db7700d into develop Nov 18, 2022
@sfc-gh-kbregula sfc-gh-kbregula added the security-assessment-completed Security assessment has been completed for PR label Nov 18, 2022
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 18, 2022
* develop: (25 commits)
  Fix CORS acronym in docstring (streamlit#5727)
  Add integration tests for Snowpark (streamlit#5543)
  Release/1.15.0 (streamlit#5720)
  Add audit_frontend_dependencies script to CODEOWNERS (streamlit#5708)
  Add label_visibility option for st.checkbox (streamlit#5705)
  Display existing column names in st.map exception and make st.map work with capital letters (streamlit#5679)
  Plotly Customization (streamlit#5681)
  Turn off theme for now (streamlit#5701)
  Add all vendored code to `make notices` (streamlit#5704)
  Audit frontend licenses (streamlit#5664)
  Surround labels in quotes (streamlit#5703)
  Add info about voting on features (streamlit#5660)
  Update issue labeling scheme to adopt new standards (streamlit#5702)
  Cached media (audio+video) replay (streamlit#5695)
  Fix docstring line wrap (streamlit#5698)
  Use specialized assertion functions (streamlit#5680)
  Release 1.14.1 (streamlit#5693)
  Image replay in cached functions (streamlit#5675)
  Add docstrings for `experimental_allow_widgets` (streamlit#5670)
  Remove `st.write` from `CachedStFunctionWarning` (streamlit#5669)
  ...
tconkling added a commit to tconkling/streamlit that referenced this pull request Nov 18, 2022
* tim/CLICleanup:
  Fix CORS acronym in docstring (streamlit#5727)
  Add integration tests for Snowpark (streamlit#5543)
  Release/1.15.0 (streamlit#5720)
  more!
  more f-strings
  cli.py: types, f-strings, fixes
@vdonato vdonato deleted the sfc-gh-kbregula-snowflake-ci branch November 2, 2023 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

security-assessment-completed Security assessment has been completed for PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants