This repository was archived by the owner on Sep 30, 2024. It is now read-only.
fix/enterpriseportal/codyaccess: allow removing rate limit overrides#64376
Merged
bobheadxi merged 2 commits intoAug 8, 2024
Merged
Conversation
This was referenced Aug 8, 2024
Member
Author
michaellzc
approved these changes
Aug 8, 2024
michaellzc
approved these changes
Aug 8, 2024
This was referenced Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

On double-checking the various Cody Gateway access management CRUD I noticed that I did not implement the ability to remove the override entirely properly - right now, removing a rate limit with
field_maskand no values results in a zero-value rate limit rather than a null one as desired.This change makes it so that if you provider a nil
*_rate_limitobject, all field paths for that object is also set to nil, removing the override and allowing the default active-license-plan-based rate limits to apply.This also adds a minor adjustment to Cody Gateway to correctly handle zero durations for rate limit intervals, which should be treated as "no access".
Test plan
Unit/integration tests, and a manual test:
sg start dotcom