Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

chore/enterpriseportal: make sf_opp_id license-level#64087

Merged
bobheadxi merged 1 commit into
mainfrom
07-25-chore_enterpriseportal_make_sf_opp_id_license-level
Aug 9, 2024
Merged

chore/enterpriseportal: make sf_opp_id license-level#64087
bobheadxi merged 1 commit into
mainfrom
07-25-chore_enterpriseportal_make_sf_opp_id_license-level

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Per feedback on https://docs.google.com/document/d/1NyBIQvZ-ziNhiz7Yuzbp4f72Gp6EUrVUoBYnnnviXi8/edit#heading=h.3lhmwnxotdew and further research, the salesforce opportunity ID must be license-level. Right now we keep this specific to the "license key" license type.

Test plan

CI

@cla-bot cla-bot Bot added the cla-signed label Jul 25, 2024
This was referenced Jul 25, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bobheadxi Graphite App

bobheadxi commented Jul 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

This was referenced Jul 25, 2024
Merged
Merged
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch 2 times, most recently from eca552a to aadc800 Compare July 25, 2024 22:01
bobheadxi
bobheadxi commented Jul 25, 2024
View reviewed changes
Comment thread lib/enterpriseportal/subscriptions/v1/subscriptions.proto Outdated
Comment on lines 143 to 148

@bobheadxi bobheadxi Jul 25, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this while here - we're opting not to use or expose this down-stack. I think we'll want to make the duplicate instance usage detection opaque, i.e. not return implementation detail via API

@bobheadxi bobheadxi marked this pull request as ready for review July 25, 2024 22:18
@bobheadxi bobheadxi requested a review from a team July 25, 2024 22:18
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch 3 times, most recently from b7eeeb0 to a54ea90 Compare July 25, 2024 23:44
@bobheadxi bobheadxi changed the base branch from 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess to 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal July 25, 2024 23:44
@bobheadxi bobheadxi mentioned this pull request Jul 25, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from c15c6c1 to 45395be Compare July 26, 2024 16:24
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from a54ea90 to 3a1d0dd Compare July 26, 2024 16:24
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from 45395be to 6bf19f4 Compare July 26, 2024 18:34
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 3a1d0dd to 3e17af1 Compare July 26, 2024 18:34
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from 6bf19f4 to b99c974 Compare July 26, 2024 19:47
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 3e17af1 to dae7215 Compare July 26, 2024 19:48
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from b99c974 to 00e169c Compare July 26, 2024 20:40
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from 59775f2 to 6e2e4da Compare August 7, 2024 23:16
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from b912af6 to bdf9cc9 Compare August 7, 2024 23:16
@bobheadxi bobheadxi force-pushed the 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal branch from 6e2e4da to c6580f1 Compare August 7, 2024 23:18
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch 2 times, most recently from dde5a0a to 4855354 Compare August 7, 2024 23:51
@bobheadxi bobheadxi changed the base branch from 07-25-feat_dotcom_track_cody_gateway_access_directly_in_enterprise_portal to 08-06-feat_enterpriseportal_license_expiry_checker August 7, 2024 23:51
@github-actions

github-actions Bot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 4855354 to 21df2d0 Compare August 8, 2024 00:58
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from 494a960 to 73beb58 Compare August 8, 2024 17:03
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 21df2d0 to 98e5ab7 Compare August 8, 2024 17:03
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from 73beb58 to 0b93a98 Compare August 8, 2024 17:09
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 98e5ab7 to 5998f37 Compare August 8, 2024 17:09
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from 0b93a98 to 37d04c3 Compare August 8, 2024 17:24
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch 2 times, most recently from fcbb5c5 to f0da579 Compare August 8, 2024 17:33
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from 2d94ada to b34e194 Compare August 8, 2024 17:39
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from f0da579 to 76247fa Compare August 8, 2024 17:39
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from b34e194 to bac27c0 Compare August 8, 2024 20:24
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 76247fa to 4424e18 Compare August 8, 2024 20:24
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from bac27c0 to 073ea4d Compare August 8, 2024 21:36
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 4424e18 to ca8c93e Compare August 8, 2024 21:36
@bobheadxi bobheadxi mentioned this pull request Aug 8, 2024
Merged
@bobheadxi bobheadxi force-pushed the 08-06-feat_enterpriseportal_license_expiry_checker branch from 073ea4d to aa013c8 Compare August 8, 2024 22:08
This was referenced Aug 9, 2024
Merged
Merged
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jac jac jac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobheadxi @jac