Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/enterpriseportal: existing subscriptions read APIs use enterprise portal DB#63927

Merged
bobheadxi merged 2 commits into
mainfrom
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db
Aug 9, 2024
Merged

feat/enterpriseportal: existing subscriptions read APIs use enterprise portal DB#63927
bobheadxi merged 2 commits into
mainfrom
07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

This change follows https://github.com/sourcegraph/sourcegraph/pull/63858 by making the existing subscriptions APIs read from the Enterprise Portal database, instead of dotcomdb, using the data that we sync from dotcomdb into Enterprise Portal.

Part of https://linear.app/sourcegraph/issue/CORE-156
Part of https://linear.app/sourcegraph/issue/CORE-158

Test plan

Updated unit and integration tests

@cla-bot cla-bot Bot added the cla-signed label Jul 18, 2024
This was referenced Jul 18, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@bobheadxi Graphite App

bobheadxi commented Jul 18, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 670d4a8 to 07f6ae6 Compare July 18, 2024 22:36
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from e81f272 to a5c9edb Compare July 18, 2024 22:39
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 07f6ae6 to d3fb2dd Compare July 18, 2024 22:39
bobheadxi
bobheadxi commented Jul 18, 2024
View reviewed changes
Comment thread cmd/enterprise-portal/internal/subscriptionsservice/adapters.go Outdated
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from a5c9edb to e786e7a Compare July 18, 2024 22:47
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from d3fb2dd to 8b66e31 Compare July 18, 2024 22:47
@bobheadxi bobheadxi marked this pull request as ready for review July 18, 2024 22:49
@bobheadxi bobheadxi requested a review from a team July 18, 2024 22:49
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from e786e7a to 889233c Compare July 19, 2024 18:16
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch 2 times, most recently from cfe855b to 4737a65 Compare July 19, 2024 18:23
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from a42857f to 6bb1bea Compare July 19, 2024 18:57
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 4737a65 to 7e86a43 Compare July 19, 2024 18:57
@bobheadxi bobheadxi changed the title feat/enterpriseportal: subscriptions read APIs use enterprise portal DB feat/enterpriseportal: existing subscriptions read APIs use enterprise portal DB Jul 19, 2024
@bobheadxi bobheadxi mentioned this pull request Jul 19, 2024
Merged
3 tasks
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 7e86a43 to 152047a Compare July 19, 2024 21:05
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from 2fa6111 to 5726960 Compare July 19, 2024 21:07
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 152047a to 16bc317 Compare July 19, 2024 21:07
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_implement_updatecodygatewayaccess branch from 5726960 to 8745870 Compare July 23, 2024 18:56
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 16bc317 to d0bce4c Compare July 23, 2024 18:56
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from fafd49d to 9eef0c9 Compare July 26, 2024 20:40
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 5ca1878 to 8202ff5 Compare July 26, 2024 21:31
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 9eef0c9 to 87aca0d Compare July 26, 2024 21:31
This was referenced Jul 26, 2024
Merged
Merged
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 8202ff5 to 42c2e80 Compare July 30, 2024 18:32
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 87aca0d to d4e0629 Compare July 30, 2024 18:32
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 42c2e80 to 92e4997 Compare July 30, 2024 18:37
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from d4e0629 to 94566ca Compare July 30, 2024 18:37
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from 92e4997 to b2b82ab Compare July 30, 2024 18:39
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 94566ca to 2fe7b30 Compare July 30, 2024 18:39
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from b2b82ab to de7b33f Compare July 30, 2024 23:08
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from 2fe7b30 to ea7742b Compare July 30, 2024 23:08
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from de7b33f to e7a0e5e Compare August 2, 2024 19:24
@bobheadxi bobheadxi force-pushed the 07-18-feat_enterpriseportal_subscriptions_read_apis_use_enterprise_portal_db branch from ea7742b to fb342bb Compare August 2, 2024 19:24
@bobheadxi bobheadxi mentioned this pull request Aug 2, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-25-chore_enterpriseportal_make_sf_opp_id_license-level branch from e7a0e5e to 9494c0f Compare August 5, 2024 20:08
@bobheadxi bobheadxi mentioned this pull request Aug 7, 2024
Merged
2 tasks
@github-actions

github-actions Bot commented Aug 7, 2024

Copy link
Copy Markdown
Contributor

Caution

License checking failed, please read: how to deal with third parties licensing.

@bobheadxi bobheadxi mentioned this pull request Aug 8, 2024
Merged
This was referenced Aug 9, 2024
Merged
Merged
Closed
unknwon
unknwon reviewed Aug 14, 2024
View reviewed changes
Comment thread cmd/enterprise-portal/service/service.go
subscriptionsservice.NewStoreV1(
subscriptionsservice.NewStoreV1Options{
DB: dbHandle,
DotcomDB: dotcomDB,

@unknwon unknwon Aug 14, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

This was referenced Aug 15, 2024
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@unknwon unknwon unknwon left review comments

@jac jac jac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobheadxi @unknwon @jac