This repository was archived by the owner on Sep 30, 2024. It is now read-only.
feat/dotcom: UI tracks Cody Gateway access directly in Enterprise Portal#64090
Merged
bobheadxi merged 6 commits intoAug 8, 2024
Conversation
This was referenced Jul 25, 2024
Member
Author
45395be to
6bf19f4
Compare
30e0562 to
c594289
Compare
6bf19f4 to
b99c974
Compare
c594289 to
db3cc38
Compare
b99c974 to
00e169c
Compare
db3cc38 to
38850a6
Compare
00e169c to
c5eda5f
Compare
This was referenced Jul 26, 2024
eseliger
approved these changes
Jul 29, 2024
Member
There was a problem hiding this comment.
is this collapsed by default, or open by default? I think it should be collapsed :)
Member
Author
There was a problem hiding this comment.
it's collapsed by default from my testing!
38850a6 to
5a3ef94
Compare
0e7192d to
8e39464
Compare
cbfae5f to
33055f4
Compare
4a2c055 to
be61fc6
Compare
33055f4 to
f2dd52c
Compare
be61fc6 to
6251655
Compare
f2dd52c to
37536df
Compare
Base automatically changed from
07-18-feat_enterpriseportal_implement_updatecodygatewayaccess
to
main
August 8, 2024 20:21
a5c0a69 to
3f90dcf
Compare
51db89e to
3f90dcf
Compare
bobheadxi
referenced
this pull request
Aug 8, 2024
…64376) On double-checking the various Cody Gateway access management CRUD I noticed that I did not implement the ability to remove the override entirely properly - right now, removing a rate limit with `field_mask` and no values results in a zero-value rate limit rather than a null one as desired. This change makes it so that if you provider a nil `*_rate_limit` object, all field paths for that object is also set to nil, removing the override and allowing the default active-license-plan-based rate limits to apply. This also adds a minor adjustment to Cody Gateway to correctly handle zero durations for rate limit intervals, which should be treated as "no access". ## Test plan Unit/integration tests, and a manual test: - Check out https://github.com/sourcegraph/sourcegraph/pull/64090 and run `sg start dotcom` - Go to a subscription, add a rate limit override  - Click the 🗑️ button to remove the rate limit override  - Repeat above on each property
Base automatically changed from
08-08-fix_enterpriseportal_codyaccess_allow_removing_rate_limit_overrides
to
main
August 8, 2024 22:20
3f90dcf to
f11ce1a
Compare
This was referenced Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Upgrades the self-contained Cody Gateway modal to only depend on Enterprise Portal to read/write Cody Gateway access.
I also made some minor tweaks to parsing empty form inputs, and also made the "Cody Gateway access token" collapsed by default, with warnings to discourage its use (opted not to remove entirely since it may be useful for dev/debugging)
Depends on:
Closes https://linear.app/sourcegraph/issue/CORE-218
Test plan
Edit the Cody Gateway access stuff, toggling it up and down. Cross-reference with the
enterprise_portal_cody_gateway_accesstable.