Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

feat/enterpriseportal: support DevOnly in list subscriptions#63837

Merged
bobheadxi merged 1 commit into
mainfrom
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions
Jul 23, 2024
Merged

feat/enterpriseportal: support DevOnly in list subscriptions#63837
bobheadxi merged 1 commit into
mainfrom
07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions

Conversation

@bobheadxi

@bobheadxi bobheadxi commented Jul 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

We need to ensure prod data does not end up in the dev Enterprise Portal instance once we start syncing. This change adds support for the DevOnly option in ListSubscriptions and strictly enforces it there (i.e. dev subscriptions cannot end up in the prod instance either).

I've tried to minimize the changes elsewhere to reduce the impact of this change for now.

Test plan

Tests

@cla-bot cla-bot Bot added the cla-signed label Jul 15, 2024
This was referenced Jul 15, 2024
Merged
Merged
@bobheadxi Graphite App

bobheadxi commented Jul 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @bobheadxi and the rest of your teammates on Graphite Graphite

This was referenced Jul 15, 2024
Merged
Merged
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 5d27309 to ea1973d Compare July 15, 2024 22:39
@bobheadxi bobheadxi requested a review from a team July 15, 2024 22:40
@bobheadxi bobheadxi marked this pull request as ready for review July 15, 2024 22:41
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from cfe43cc to a22ee20 Compare July 16, 2024 18:31
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from ea1973d to 5061fd6 Compare July 16, 2024 18:31
@bobheadxi bobheadxi mentioned this pull request Jul 16, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 5061fd6 to aa59edf Compare July 16, 2024 18:32
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from f7e511c to 0e3f450 Compare July 16, 2024 22:15
@bobheadxi bobheadxi mentioned this pull request Jul 16, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from aa59edf to 8ff52ad Compare July 16, 2024 22:15
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 0e3f450 to 02210dd Compare July 16, 2024 22:24
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 8ff52ad to a52025d Compare July 16, 2024 22:24
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 02210dd to 173d040 Compare July 16, 2024 22:25
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from a52025d to 10e57d2 Compare July 16, 2024 22:25
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 173d040 to a80dd1f Compare July 16, 2024 22:51
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 10e57d2 to b990a28 Compare July 16, 2024 22:51
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from a80dd1f to 63167e2 Compare July 16, 2024 22:52
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from b990a28 to 3f5c924 Compare July 16, 2024 22:52
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 63167e2 to 988e464 Compare July 16, 2024 23:06
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 3f5c924 to b732ac4 Compare July 16, 2024 23:06
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 988e464 to e180a53 Compare July 17, 2024 21:16
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from b732ac4 to 00147a6 Compare July 17, 2024 21:17
@bobheadxi bobheadxi mentioned this pull request Jul 18, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 00147a6 to cf5d11e Compare July 18, 2024 20:53
@bobheadxi bobheadxi mentioned this pull request Jul 18, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from cc8e759 to 9f0f026 Compare July 18, 2024 21:34
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from cf5d11e to 5e27ca1 Compare July 18, 2024 21:34
@bobheadxi bobheadxi mentioned this pull request Jul 18, 2024
Merged
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 9f0f026 to f7ac8de Compare July 19, 2024 18:16
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 5e27ca1 to 764c767 Compare July 19, 2024 18:16
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from f7ac8de to c85e1e3 Compare July 19, 2024 18:56
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 764c767 to 5edbbdd Compare July 19, 2024 18:56
@bobheadxi bobheadxi mentioned this pull request Jul 19, 2024
Merged
3 tasks
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from c85e1e3 to a23cef5 Compare July 19, 2024 21:07
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 5edbbdd to 883f5fb Compare July 19, 2024 21:07
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from a23cef5 to 3a2cc30 Compare July 23, 2024 18:55
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 883f5fb to 64a0ee8 Compare July 23, 2024 18:55
@bobheadxi bobheadxi force-pushed the 07-12-feat_enterpriseportal_implement_subscription_conditions branch from 3a2cc30 to 92614a2 Compare July 23, 2024 19:21
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from 64a0ee8 to b77567d Compare July 23, 2024 19:21
Base automatically changed from 07-12-feat_enterpriseportal_implement_subscription_conditions to main July 23, 2024 19:27
@bobheadxi bobheadxi force-pushed the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch from b77567d to c236467 Compare July 23, 2024 22:09
@bobheadxi bobheadxi enabled auto-merge (squash) July 23, 2024 22:09
@bobheadxi bobheadxi merged commit e0b959b into main Jul 23, 2024
@bobheadxi bobheadxi deleted the 07-15-feat_enterpriseportal_support_devonly_in_list_subscriptions branch July 23, 2024 22:20
evict
evict reviewed Jul 24, 2024
View reviewed changes
Comment thread cmd/enterprise-portal/internal/dotcomdb/dotcomdb.go
This was referenced Jul 24, 2024
Merged
Merged
Merged
Merged
Merged
This was referenced Aug 2, 2024
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@evict evict evict left review comments

@jac jac jac approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobheadxi @evict @jac