This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Add observability to chunked messages#62825
Merged
eseliger merged 1 commit intoMay 21, 2024
Merged
Conversation
This was referenced May 21, 2024
Member
Author
ggilmore
approved these changes
May 21, 2024
858cb3d to
44b9087
Compare
Base automatically changed from
es/05-17-gitserverdeprecateexecandremovelocalgit
to
main
May 21, 2024 16:19
This PR adds event markers for the chunked sender. In tracing, this will tell how many messages and how many items in a message we sent. That should help understand better how much overhead we're incurring by splitting the data into multiple gRPC chunks. Test plan: Ran Jaeger locally, got good markers and interesting insights. For ReadDir, we batch roughly 8k records in one message.
956bcdd to
ec039d1
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds event markers for the chunked sender. In tracing, this will tell how many messages and how many items in a message we sent. That should help understand better how much overhead we're incurring by splitting the data into multiple gRPC chunks.
Test plan:
Ran Jaeger locally, got good markers and interesting insights. For ReadDir, we batch roughly 8k records in one message.