This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Move implementation of HasCommitAfter to caller#62520
Merged
eseliger merged 1 commit intoMay 10, 2024
Merged
Conversation
This was referenced May 8, 2024
Member
Author
ggilmore
approved these changes
May 8, 2024
pjlast
approved these changes
May 9, 2024
cde2256 to
8ec8fdf
Compare
e3977df to
18d5fad
Compare
8ec8fdf to
c0e2968
Compare
18d5fad to
4a5095f
Compare
c0e2968 to
985143d
Compare
4a5095f to
ba2b1e9
Compare
985143d to
54e601c
Compare
ba2b1e9 to
78320cc
Compare
This was referenced May 10, 2024
54e601c to
6750cef
Compare
78320cc to
4585dee
Compare
6750cef to
a4c639d
Compare
4585dee to
65dc9a0
Compare
a4c639d to
36c1679
Compare
This is only used in one place, so we're moving the implementation to the caller. Gitserver client only exposes gRPC methods without additional logic on top. Test plan: Kept the existing tests but rewrote them to test Commits instead so we don't lose coverage for this.
65dc9a0 to
7d13e41
Compare
Member
Author
This was referenced May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only used in one place, so we're moving the implementation to the caller. Gitserver client only exposes gRPC methods without additional logic on top.
Closes https://github.com/sourcegraph/sourcegraph/issues/61688
Test plan:
Kept the existing tests but rewrote them to test Commits instead so we don't lose coverage for this.