This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Move CommitsUniqueToBranch to callsite#62514
Merged
eseliger merged 1 commit intoMay 10, 2024
Conversation
Member
Author
328eaa6 to
52ad1ff
Compare
a23ce9f to
ca98456
Compare
This was referenced May 8, 2024
Graphite Automations"Assign Source to gitserver PRs" took an action on this PR • (05/08/24)3 assignees were added to this PR based on Geoffrey Gilmore's automation. |
ggilmore
reviewed
May 8, 2024
ggilmore
reviewed
May 8, 2024
ggilmore
approved these changes
May 8, 2024
52ad1ff to
f1f50cb
Compare
ca98456 to
c5a4188
Compare
f1f50cb to
2bf43b1
Compare
c5a4188 to
7d955ac
Compare
2bf43b1 to
bba7e86
Compare
7d955ac to
99767c0
Compare
This was referenced May 10, 2024
bba7e86 to
5cb7b4d
Compare
99767c0 to
4c79f9f
Compare
e0513d4 to
0301fe4
Compare
d83a205 to
e9df5e4
Compare
0301fe4 to
c74a757
Compare
Base automatically changed from
es/05-08-gitserverimplementcommitsuniquetobranchusingcommits
to
main
May 10, 2024 23:07
This has only one caller and is now implemented using existing gitserver stuff, so I'm moving this custom response mapping to where it's used. One less API we need to expose via gRPC. Test plan: Adjusted tests, and existing E2E tests still pass.
e9df5e4 to
b130050
Compare
Member
Author
This was referenced May 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has only one caller and is now implemented using existing gitserver stuff, so I'm moving this custom response mapping to where it's used. One less API we need to expose via gRPC.
Closes https://github.com/sourcegraph/sourcegraph/issues/62102
Test plan:
Adjusted tests, and existing E2E tests still pass.