This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Deprecate Exec and remove localGit#62773
Merged
Merged
Conversation
This was referenced May 17, 2024
This was referenced May 17, 2024
Member
Author
ggilmore
approved these changes
May 20, 2024
c380fec to
b29690c
Compare
7f51c08 to
858cb3d
Compare
b29690c to
ec0803e
Compare
Base automatically changed from
es/05-16-gitserverremoveanddeprecateno_timeoutoptionfromexec
to
main
May 21, 2024 16:05
We no longer have any endpoints using the exec endpoint, so we can deprecate it in this PR, and a follow up PR which can be merged after early June will entirely drop it then. Test plan: Removed dead code and annotated proto, the Go compiler, buf compiler, and nogo checks should find any problems from that.
858cb3d to
44b9087
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer have any endpoints using the exec endpoint, so we can deprecate it in this PR, and a follow up PR which can be merged after early June will entirely drop it then.
Works on https://github.com/sourcegraph/sourcegraph/issues/62099.
Test plan:
Removed dead code and annotated proto, the Go compiler, buf compiler, and nogo checks should find any problems from that.