This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Reduce number of git config invocations#62615
Merged
eseliger merged 1 commit intoMay 13, 2024
Conversation
This was referenced May 13, 2024
Member
Author
bf8ed84 to
88e9cca
Compare
1fe128f to
79cba1f
Compare
pjlast
approved these changes
May 13, 2024
88e9cca to
dbc60f7
Compare
79cba1f to
804d532
Compare
dbc60f7 to
ce5274c
Compare
Base automatically changed from
es/05-13-gitservermoveremovalofstraytmppackfilestojanitor
to
main
May 13, 2024 14:44
Using config is fairly convenient, but got somewhat out of hand. On dotcom, we call this millions of times, because the janitor runs frequently and there are a lot of repos. Instead, for a few simple things we now use a different mechanism that has less overhead (also, we only abused the git config, those values are of no interest to git itself). 1. The timestamp for the last size calculation is now stored as the mtime of a magic file in the repo dir. 2. The repoType is only loaded when there is a reclone reason, and we might want to skip over Perforce repos Test plan: Added a basic test, and integration tests still pass.
804d532 to
0b9d527
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using config is fairly convenient, but got somewhat out of hand. On dotcom, we call this millions of times, because the janitor runs frequently and there are a lot of repos.
Instead, for a few simple things we now use a different mechanism that has less overhead (also, we only abused the git config, those values are of no interest to git itself).
Test plan:
Added a basic test, and integration tests still pass.