This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Move repo timestamp updates to caller#62610
Merged
eseliger merged 1 commit intoMay 13, 2024
Merged
Conversation
Member
Author
This was referenced May 13, 2024
This was referenced May 13, 2024
931fa7b to
941522d
Compare
pjlast
approved these changes
May 13, 2024
Base automatically changed from
es/05-12-gitserveraddapitoenumeratereposondisk
to
main
May 13, 2024 12:25
This is a small step towards making gitserver itself less dependent on Sourcegraph concepts like the database, by making the repo-updater scheduler (later, this can be coordinator) write to the DB instead. Note: Until we decide what to do with ensurerevision which schedules out-of-band updates that affect concurrency and the control flow, I decided to inline this behavior there to make it very explicit. Test plan: Existing tests are still passing.
941522d to
dcd6c6c
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small step towards making gitserver itself less dependent on Sourcegraph concepts like the database, by making the repo-updater scheduler (later, this can be coordinator) write to the DB instead.
Note: Until we decide what to do with ensurerevision which schedules out-of-band updates that affect concurrency and the control flow, I decided to inline this behavior there to make it very explicit.
Test plan:
Existing tests are still passing.