This repository was archived by the owner on Sep 30, 2024. It is now read-only.
gitserver: Implement RefHash in backend#62612
Merged
Merged
Conversation
This was referenced May 13, 2024
Member
Author
This was referenced May 13, 2024
8b57b06 to
5011142
Compare
5f7b386 to
d2f4ebf
Compare
pjlast
approved these changes
May 13, 2024
5011142 to
fa2bead
Compare
d2f4ebf to
bac718c
Compare
Base automatically changed from
es/05-13-gitserverimplementlatestcommittimestampinbackend
to
main
May 13, 2024 13:37
This PR moves the implementation of ComputeRefHash to the GitBackend interface and reduces the amount of memory needed by it. We get proper tracking of the command by that, including error logs, resource usage, invocation count etc. Since there is no 1000% guarantee that this didn't change the hash, I opted for resetting the last changed value and recomputing from scratch, by changing the path of the file to _v2. Test plan: Tests are still passing.
bac718c to
b743fc5
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the implementation of ComputeRefHash to the GitBackend interface and reduces the amount of memory needed by it. We get proper tracking of the command by that, including error logs, resource usage, invocation count etc.
Since there is no 1000% guarantee that this didn't change the hash, I opted for resetting the last changed value and recomputing from scratch, by changing the path of the file to _v2.
Test plan:
Tests are still passing.